rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917311413
##
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917303018
##
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##
@@ -76,6 +67,31 @@ protected ParquetValueReader createReader(
protected abstrac
danielcweeks commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917315859
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
danielcweeks commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917315859
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917317907
##
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917319575
##
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916840498
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
Fokko commented on code in PR #1285:
URL: https://github.com/apache/iceberg-python/pull/1285#discussion_r1916863476
##
dev/provision.py:
##
@@ -401,3 +401,27 @@
)
spark.sql(f"ALTER TABLE {catalog_name}.default.test_empty_scan_ordered_str
WRITE ORDERED BY id")
spa
Fokko closed pull request #1323: Test: Bump Iceberg-Java to 1.7.1
URL: https://github.com/apache/iceberg-python/pull/1323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
nastra merged PR #11797:
URL: https://github.com/apache/iceberg/pull/11797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
danielcweeks commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916982539
##
format/spec.md:
##
@@ -654,17 +656,18 @@ The `first_row_id` is only inherited for added data
files. The inherited value m
A snapshot consists of the follo
adutra commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1916787886
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
Fokko commented on PR #1242:
URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2593215982
@shiv-io Gentle ping :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Fokko commented on code in PR #1498:
URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1916858843
##
pyiceberg/exceptions.py:
##
@@ -14,6 +14,9 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limi
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916861998
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -288,7 +293,9 @@ public String toString() {
Map refs,
List statisticsFiles,
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916858569
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916833571
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916819546
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -288,7 +293,9 @@ public String toString() {
Map refs,
List statisticsFiles,
Lis
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916838133
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916839420
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916834406
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
Fokko commented on PR #1377:
URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2593287814
Fixing conflicts to see where we are with 3.13 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916827033
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1468,6 +1514,45 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
re
amogh-jahagirdar opened a new pull request, #11975:
URL: https://github.com/apache/iceberg/pull/11975
Backport #11273 to Spark 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
amogh-jahagirdar commented on code in PR #11975:
URL: https://github.com/apache/iceberg/pull/11975#discussion_r1916969098
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##
@@ -28,6 +28,7 @@
import java.util.Arrays;
import java.u
Fokko merged PR #1362:
URL: https://github.com/apache/iceberg-python/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
amogh-jahagirdar commented on code in PR #11975:
URL: https://github.com/apache/iceberg/pull/11975#discussion_r1916971610
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##
@@ -28,6 +28,7 @@
import java.util.Arrays;
import java.u
MChamberlin opened a new pull request, #1517:
URL: https://github.com/apache/iceberg-python/pull/1517
Some REST catalog implementations (including the Snowflake Polaris catalog)
return a 401 `UnauthorizedError` when a token is expired. Refreshing the token,
as is done for 419 responses, res
RussellSpitzer opened a new pull request, #11976:
URL: https://github.com/apache/iceberg/pull/11976
Split out from #11948
Working on the row-lineage implementation made it clear that we needed a way
to get information from the Snapshot object propagated into the Metadata layer.
Spec
kevinjqliu commented on issue #1514:
URL:
https://github.com/apache/iceberg-python/issues/1514#issuecomment-2593468214
> Airflow. Any advice on resolving this conflict or workarounds to make
PyIceberg work with SQLAlchemy 1.4.x while maintaining Airflow functionality
would be greatly appre
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917068017
##
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##
@@ -517,4 +517,11 @@ public void applyTo(ViewMetadata.Builder
viewMetadataBuilder) {
viewMetad
lliangyu-lin commented on code in PR #11967:
URL: https://github.com/apache/iceberg/pull/11967#discussion_r1917079197
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -561,14 +561,11 @@ public Scan buildChangelogScan() {
boole
ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1916789379
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -133,4 +134,27 @@ private static Collection mergeStats(
return statsMap.values();
amogh-jahagirdar merged PR #11975:
URL: https://github.com/apache/iceberg/pull/11975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #11975:
URL: https://github.com/apache/iceberg/pull/11975#issuecomment-2593599957
Thanks @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ajantha-bhat commented on PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2593651091
@aokolnychyi, @rdblue, @RussellSpitzer: I have reworked on the PR to use
Internal writers and readers. PR is much simpler and no need to handle those
conversions now. I can rebase
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916813085
##
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##
@@ -282,6 +283,29 @@ public Snapshot apply() {
throw new RuntimeIOException(e, "Failed to wri
ForeverAngry commented on PR #914:
URL: https://github.com/apache/iceberg-python/pull/914#issuecomment-2593097982
@chinmay-bhat I have been working on this as well, would you want to
partner on completing this pr?
--
This is an automated message from the Apache Git Service.
To respond to
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916864220
##
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##
@@ -61,7 +63,9 @@ class BaseSnapshot implements Snapshot {
String operation,
Map s
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916867998
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
manuzhang opened a new pull request, #11974:
URL: https://github.com/apache/iceberg/pull/11974
https://github.com/apache/iceberg/pull/11654 attempted to fix flaky tests
(https://github.com/apache/iceberg/issues/11066,
https://github.com/apache/iceberg/issues/11651) due to timeout by addi
wgtmac commented on PR #30:
URL: https://github.com/apache/iceberg-cpp/pull/30#issuecomment-2593244484
cc @lidavidm @MisterRaindrop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
wgtmac commented on issue #2:
URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2593298886
It might be a good time to create a PR to prototype a `FileReader` interface
for Json/Parquet/Avro. Unfortunately I don't have time this week (and perhaps
next week).
> The curre
bryanck commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1916919842
##
kafka-connect/build.gradle:
##
@@ -242,3 +243,19 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDistZip
pitrou commented on PR #30:
URL: https://github.com/apache/iceberg-cpp/pull/30#issuecomment-2593303684
Has iceberg-cpp decided on an IO strategy already?
It might be more productive to start writing the IO-less components, such as
parsing the various metadata files, etc.
--
This is
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916925759
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -43,7 +43,16 @@ public void testJsonConversion() throws IOException {
Snapshot exp
Fokko commented on code in PR #1362:
URL: https://github.com/apache/iceberg-python/pull/1362#discussion_r1916928078
##
pyiceberg/manifest.py:
##
@@ -93,9 +93,16 @@ def __repr__(self) -> str:
class FileFormat(str, Enum):
-AVRO = "AVRO"
-PARQUET = "PARQUET"
-ORC =
danielcweeks commented on PR #11906:
URL: https://github.com/apache/iceberg/pull/11906#issuecomment-2593735172
@ismailsimsek [my
issue](https://github.com/apache/iceberg/pull/7914#issuecomment-2557715049)
with this PR is the same as the previous pr. This isn't a scaleable solution.
The f
danielcweeks commented on code in PR #11906:
URL: https://github.com/apache/iceberg/pull/11906#discussion_r1917214900
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##
@@ -292,19 +294,49 @@ private Dataset validFileIdentDS()
dmitrykoval commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1917218615
##
format/spec.md:
##
@@ -205,15 +205,40 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`uuid`**
nastra merged PR #11954:
URL: https://github.com/apache/iceberg/pull/11954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916272565
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -43,7 +43,16 @@ public void testJsonConversion() throws IOException {
Snapshot expected =
nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916272565
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -43,7 +43,16 @@ public void testJsonConversion() throws IOException {
Snapshot expected =
chil-pavn opened a new pull request, #254:
URL: https://github.com/apache/iceberg-go/pull/254
Part of #63 . Added For Create, Drop and Rename operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Fokko commented on issue #11968:
URL: https://github.com/apache/iceberg/issues/11968#issuecomment-2592233055
I was trying out the Nightly Snapshot for PyIceberg, and noticed that we
don't produce any deletion vectors (yet):
```
spark-sql (default)> CREATE OR REPLACE TABLE tes
chil-pavn commented on PR #240:
URL: https://github.com/apache/iceberg-go/pull/240#issuecomment-2592240873
hey @zeroshade i am closing this pull request as i don't think it is any
more relevant. Will open a new PR for the unit tests.
--
This is an automated message from the Apache Git Ser
chil-pavn closed pull request #240: Implemented Remaining Catalog operations
for REST catalog
URL: https://github.com/apache/iceberg-go/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
gaborkaszab commented on code in PR #11548:
URL: https://github.com/apache/iceberg/pull/11548#discussion_r1916317702
##
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##
@@ -82,6 +82,8 @@ public class HTTPClient implements RESTClient {
static final int REST_MAX_C
nastra merged PR #11971:
URL: https://github.com/apache/iceberg/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
munendrasn commented on code in PR #11548:
URL: https://github.com/apache/iceberg/pull/11548#discussion_r1916337762
##
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##
@@ -82,6 +82,8 @@ public class HTTPClient implements RESTClient {
static final int REST_MAX_CO
steveloughran commented on PR #11837:
URL: https://github.com/apache/iceberg/pull/11837#issuecomment-2592695395
I'm going to suggest some tests of failure handling to see what happens there
* missing file (all should ignore)
* putting a non-empty directory where one of the file path
adutra commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917090457
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
adutra commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917092295
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
kevinjqliu commented on PR #1517:
URL: https://github.com/apache/iceberg-python/pull/1517#issuecomment-2593673519
Hey @MChamberlin Thanks for the PR.
I have some concerns related to this approach
> Some REST catalog implementations (including the Snowflake Polaris
catalog) ret
danielcweeks commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1917178042
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time q
ismailsimsek commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917177902
##
kafka-connect/build.gradle:
##
@@ -242,3 +243,19 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
assemble.dependsOn distZip, hiveDi
danielcweeks commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917186435
##
gradle/libs.versions.toml:
##
@@ -159,6 +161,7 @@ jaxb-runtime = { module =
"org.glassfish.jaxb:jaxb-runtime", version.ref = "jaxb
kafka-clients = { module
danielcweeks commented on code in PR #11936:
URL: https://github.com/apache/iceberg/pull/11936#discussion_r1917185969
##
gradle/libs.versions.toml:
##
@@ -100,6 +101,7 @@ avro-avro = { module = "org.apache.avro:avro", version.ref
= "avro" }
awssdk-bom = { module = "software.am
rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917325058
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##
@@ -330,6 +382,17 @@ public void write(int repetitionLevel, CharSequence value)
{
Fokko opened a new pull request, #1520:
URL: https://github.com/apache/iceberg-python/pull/1520
First version with `Fsspec`. Will check with PyArrow tomorrow, but that one
seems to be lacking the SAS token:
https://arrow.apache.org/docs/cpp/api/filesystem.html#azure-filesystem
rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917320632
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##
@@ -401,6 +404,17 @@ public ByteBuffer read(ByteBuffer reuse) {
}
}
+ publi
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917359444
##
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##
@@ -517,4 +517,11 @@ public void applyTo(ViewMetadata.Builder
viewMetadataBuilder) {
v
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917361248
##
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##
@@ -282,6 +283,29 @@ public Snapshot apply() {
throw new RuntimeIOException(e, "Faile
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917362724
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1468,6 +1514,45 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917362724
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1468,6 +1514,45 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917369612
##
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##
@@ -144,6 +144,13 @@ public static long getLong(String property, JsonNode node)
{
return
RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917382256
##
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ndrluis commented on PR #1521:
URL: https://github.com/apache/iceberg-python/pull/1521#issuecomment-2594022037
@Fokko I created this PR to fix the Spark download issue since version 3.5.3
is not available.
--
This is an automated message from the Apache Git Service.
To respond to the mess
rdblue commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917395711
##
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##
@@ -372,6 +373,7 @@ public static TableMetadata fromJson(String
metadataLocation, JsonNode node)
rdblue commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1917398167
##
core/src/test/java/org/apache/iceberg/MetadataTestUtils.java:
##
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
201 - 280 of 280 matches
Mail list logo
