RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916864220
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -61,7 +63,9 @@ class BaseSnapshot implements Snapshot {
String operation,
Map<String, String> summary,
Integer schemaId,
- String manifestList) {
+ String manifestList,
+ Long firstRowId,
+ Long addedRows) {
Review Comment:
Here I think there is more of an argument to have multiple constructors
since there isn't a builder, but I"m still hesitant to add another constructor
here. What instances to we have where we want to make a new Snapshot and not
have these fields explicitly specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
