RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916861998
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -288,7 +293,9 @@ public String toString() {
Map<String, SnapshotRef> refs,
List<StatisticsFile> statisticsFiles,
List<PartitionStatisticsFile> partitionStatisticsFiles,
- List<MetadataUpdate> changes) {
+ List<MetadataUpdate> changes,
+ boolean rowLineage,
Review Comment:
I think if we have a builder then it doesn't really make sense to have
multiple constructors. All usages should be going through the builder, the test
classes are the only ones (other than RewritePaths) that use the raw
constructor and they do so incorrectly imho and should be using their own
builder as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
