Fokko commented on code in PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362#discussion_r1916928078
########## pyiceberg/manifest.py: ########## @@ -93,9 +93,16 @@ def __repr__(self) -> str: class FileFormat(str, Enum): - AVRO = "AVRO" - PARQUET = "PARQUET" - ORC = "ORC" + AVRO = "AVRO", "avro" + PARQUET = "PARQUET", "parquet" + ORC = "ORC", "orc" + + def __new__(cls, value, *value_aliases): Review Comment: ```suggestion def __new__(cls, value: str, *value_aliases: List[str]) -> "FileFormat": ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org