gaborkaszab commented on code in PR #11548:
URL: https://github.com/apache/iceberg/pull/11548#discussion_r1916317702


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -82,6 +82,8 @@ public class HTTPClient implements RESTClient {
   static final int REST_MAX_CONNECTIONS_DEFAULT = 100;
   static final String REST_MAX_CONNECTIONS_PER_ROUTE = 
"rest.client.connections-per-route";
   static final int REST_MAX_CONNECTIONS_PER_ROUTE_DEFAULT = 100;
+  private static final String REST_USE_SYSTEM_PROPERTIES = 
"rest.client.use-system-properties";
+  private static final boolean REST_USE_SYSTEM_PROPERTIES_DEFAULT = true;

Review Comment:
   If I'm not mistaken the current behaviour doesn't use system properties. 
With this change we seem to change that behaviour and one would have to turn 
that off manually by setting a property to false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to