RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1917382256
########## core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java: ########## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.Assert.assertThrows; +import static org.junit.jupiter.api.Assumptions.assumeTrue; + +import java.io.File; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.types.Types; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.io.TempDir; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.FieldSource; + +public class TestRowLineageMetadata { + + private static final String TEST_LOCATION = "s3://bucket/test/location"; + + @TempDir protected File tableDir = null; + + private static final Schema TEST_SCHEMA = + new Schema( + 7, + Types.NestedField.required(1, "x", Types.LongType.get()), + Types.NestedField.required(2, "y", Types.LongType.get(), "comment"), + Types.NestedField.required(3, "z", Types.LongType.get())); + + private TableMetadata.Builder builderFor(int formatVersion) { + return TableMetadata.buildFromEmpty(formatVersion).enableRowLineage(); + } + + private TableMetadata baseMetadata(int formatVersion) { + return builderFor(formatVersion) + .addSchema(TEST_SCHEMA) + .setLocation(TEST_LOCATION) + .addPartitionSpec(PartitionSpec.unpartitioned()) + .addSortOrder(SortOrder.unsorted()) + .build(); + } + + @AfterEach + public void cleanup() { + TestTables.clearTables(); + } + + @ParameterizedTest + @FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS") + public void testRowLineageSupported(int formatVersion) { + if (formatVersion == TableMetadata.MIN_FORMAT_VERSION_ROW_LINEAGE) { + assertThat(builderFor(formatVersion)).isNotNull(); + } else { + IllegalArgumentException notSupported = + assertThrows( + IllegalArgumentException.class, + () -> TableMetadata.buildFromEmpty(formatVersion).enableRowLineage()); + assertThat(notSupported.getMessage()).contains("Cannot use row lineage"); Review Comment: Got it, I forgot which one we were using and hit a checkstyle bug that told me not to use junit5? I don't actually know which libraries are which -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
