rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917303018
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -76,6 +67,31 @@ protected ParquetValueReader<T> createReader(
protected abstract ParquetValueReader<T> createStructReader(
List<Type> types, List<ParquetValueReader<?>> fieldReaders,
Types.StructType structType);
+ protected ParquetValueReaders.PrimitiveReader<?>
fixedReader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected ParquetValueReaders.PrimitiveReader<?>
int96Reader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected Optional<ParquetValueReader<?>> dateReader(ColumnDescriptor desc) {
Review Comment:
These should not return `Optional`:
* Iceberg generally prefers returning `null` over using `Optional`
* The existing methods (like `createStructReader`) do not wrap return types
in `Optional`
* These methods should always return a valid reader, or should throw an
exception to signal that something is not supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
