rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917320632
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -401,6 +404,17 @@ public ByteBuffer read(ByteBuffer reuse) {
}
}
+ public static class UUIDReader extends PrimitiveReader<UUID> {
Review Comment:
Rather than making the classes here public, I would prefer to introduce
factory methods like we have for the Avro readers. I think that gives us more
flexibility to change implementations and move classes around without worrying
because none of them need to be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
