Re: [PR] Infra: Add 1.7.0 to issue template [iceberg]

RussellSpitzer commented on code in PR #11491: URL: https://github.com/apache/iceberg/pull/11491#discussion_r1834569335 ## .github/ISSUE_TEMPLATE/iceberg_bug_report.yml: ## @@ -28,7 +28,8 @@ body: description: What Apache Iceberg version are you using? multiple: fa

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834629086 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [PR] Flink: Add RowConverter for Iceberg Source [iceberg]

abharath9 commented on PR #11301: URL: https://github.com/apache/iceberg/pull/11301#issuecomment-2465253932 @stevenzwu Hope you are doing well. The pr has been open for a while. If everything looks good can you approve the pr. Thanks -- This is an automated message from the Apache Git Ser

[PR] Adds Versioned 1.7.0 Release Docs [iceberg]

RussellSpitzer opened a new pull request, #11496: URL: https://github.com/apache/iceberg/pull/11496 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Core: Support commits with DVs [iceberg]

danielcweeks commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835104546 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fi

Re: [PR] Spark partial limit push down [iceberg]

RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1835109730 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestLimitPushDown.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Spark partial limit push down [iceberg]

RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1835110026 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestLimitPushDown.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Spark partial limit push down [iceberg]

RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1835113147 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestLimitPushDown.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundati

[PR] Bump getdaft from 0.3.9 to 0.3.11 [iceberg-python]

dependabot[bot] opened a new pull request, #1308: URL: https://github.com/apache/iceberg-python/pull/1308 Bumps [getdaft](https://github.com/Eventual-Inc/Daft) from 0.3.9 to 0.3.11. Release notes Sourced from https://github.com/Eventual-Inc/Daft/releases";>getdaft's releases.

Re: [PR] Bump getdaft from 0.3.9 to 0.3.10 [iceberg-python]

dependabot[bot] closed pull request #1303: Bump getdaft from 0.3.9 to 0.3.10 URL: https://github.com/apache/iceberg-python/pull/1303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump getdaft from 0.3.9 to 0.3.10 [iceberg-python]

dependabot[bot] commented on PR #1303: URL: https://github.com/apache/iceberg-python/pull/1303#issuecomment-2465843380 Superseded by #1308. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835114428 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1830093248 ## .palantir/revapi.yml: ## @@ -1145,6 +1145,15 @@ acceptedBreaks: new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus org.apache.iceberg.Bas

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

flyrain commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1830093248 ## .palantir/revapi.yml: ## @@ -1145,6 +1145,15 @@ acceptedBreaks: new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus org.apache.iceberg.Bas

Re: [PR] Flink: Maintenance - RewriteDataFiles [iceberg]

pvary commented on PR #11497: URL: https://github.com/apache/iceberg/pull/11497#issuecomment-2465659348 @aokolnychyi, @RussellSpitzer, @szehon-ho - I have touched the Spark compaction as well to remove duplicate code, and move it to the `core` module. Could you please check the Spark, and t

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835114428 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Bump getdaft from 0.3.9 to 0.3.11 [iceberg-python]

Fokko merged PR #1308: URL: https://github.com/apache/iceberg-python/pull/1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Bump mkdocstrings-python from 1.11.1 to 1.12.2 [iceberg-python]

Fokko merged PR #1302: URL: https://github.com/apache/iceberg-python/pull/1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Boto Glue standard retry policy with configuration [iceberg-python]

Fokko commented on code in PR #1307: URL: https://github.com/apache/iceberg-python/pull/1307#discussion_r1835128819 ## pyiceberg/catalog/glue.py: ## @@ -305,7 +308,18 @@ def __init__(self, name: str, **properties: Any): aws_secret_access_key=get_first_property_value

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

rocco408 commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1834604654 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.NestedFiel

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834831646 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834836340 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834692436 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] Spec: Explicitly specify `operation` as a required field of Snapshot's `summary` field [iceberg]

sungwy commented on PR #11355: URL: https://github.com/apache/iceberg/pull/11355#issuecomment-2465779782 Hi @RussellSpitzer appreciate the chase up 🙂 I've resolved the conflicts - does this look good to merge? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Spec: Explicitly specify `operation` as a required field of Snapshot's `summary` field [iceberg]

RussellSpitzer commented on PR #11355: URL: https://github.com/apache/iceberg/pull/11355#issuecomment-2465792213 All good with me @sungwy ! Thanks for the PR and thanks @Fokko, @nastra and @kevinjqliu for reviewing -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Spec: Explicitly specify `operation` as a required field of Snapshot's `summary` field [iceberg]

RussellSpitzer merged PR #11355: URL: https://github.com/apache/iceberg/pull/11355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Spark partial limit push down [iceberg]

RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1835096536 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java: ## @@ -114,16 +132,29 @@ private String[][] computePreferredLocations() {

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834624350 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

[PR] Docs: Site Update for 1.7.0 Release [iceberg]

RussellSpitzer opened a new pull request, #11494: URL: https://github.com/apache/iceberg/pull/11494 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] Add Version Docs for 1.7.0 [iceberg]

RussellSpitzer opened a new pull request, #11493: URL: https://github.com/apache/iceberg/pull/11493 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834700957 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834825302 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

RussellSpitzer commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1835050238 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.Nest

Re: [PR] OpenAPI: Update Snapshots to be a common denominator of V1 and V2 specs [iceberg]

sungwy closed pull request #11353: OpenAPI: Update Snapshots to be a common denominator of V1 and V2 specs URL: https://github.com/apache/iceberg/pull/11353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

RussellSpitzer commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1835074284 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.Nest

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

huaxingao commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1834751371 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.NestedFie

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834805599 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834821906 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] Docs: Site Update for 1.7.0 Release [iceberg]

Fokko merged PR #11494: URL: https://github.com/apache/iceberg/pull/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Infra: Add 1.7.0 to issue template [iceberg]

Fokko merged PR #11491: URL: https://github.com/apache/iceberg/pull/11491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Let revapi compare against 1.7.0 [iceberg]

Fokko merged PR #11490: URL: https://github.com/apache/iceberg/pull/11490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

RussellSpitzer commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1834980539 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.Nest

Re: [I] Flink: Maintenance - RewriteDataFiles [iceberg]

pvary closed issue #10303: Flink: Maintenance - RewriteDataFiles URL: https://github.com/apache/iceberg/issues/10303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] Flink: Maintenance - RewriteDataFiles [iceberg]

pvary commented on issue #10303: URL: https://github.com/apache/iceberg/issues/10303#issuecomment-2465517687 Implemented in #11497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Infra: Add 1.7.0 to issue template [iceberg]

amogh-jahagirdar commented on code in PR #11491: URL: https://github.com/apache/iceberg/pull/11491#discussion_r1834913426 ## .github/ISSUE_TEMPLATE/iceberg_bug_report.yml: ## @@ -28,7 +28,8 @@ body: description: What Apache Iceberg version are you using? multiple:

Re: [PR] Adds Javadocs for 1.7.0 Release [iceberg]

amogh-jahagirdar merged PR #11498: URL: https://github.com/apache/iceberg/pull/11498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Adds Versioned 1.7.0 Release Docs [iceberg]

amogh-jahagirdar merged PR #11496: URL: https://github.com/apache/iceberg/pull/11496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Docs: Site Update for 1.7.0 Release [iceberg]

Fokko commented on code in PR #11494: URL: https://github.com/apache/iceberg/pull/11494#discussion_r1834915958 ## site/docs/releases.md: ## @@ -72,10 +72,90 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.7.0 release + +The 1.7.0

Re: [PR] Docs: Site Update for 1.7.0 Release [iceberg]

Fokko commented on code in PR #11494: URL: https://github.com/apache/iceberg/pull/11494#discussion_r1834916859 ## site/docs/releases.md: ## @@ -72,10 +72,90 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.7.0 release + +The 1.7.0

Re: [PR] Flink: Maintenance - RewriteDataFiles [iceberg]

RussellSpitzer commented on PR #11497: URL: https://github.com/apache/iceberg/pull/11497#issuecomment-2465663577 Could we break this up into smaller PR's? I think just one for the refactoring of classes out of the Spark Module would be a good first step? -- This is an automated message fr

Re: [I] Is `pyiceberg.Table` thread-safe? [iceberg-python]

chengchengpei commented on issue #1305: URL: https://github.com/apache/iceberg-python/issues/1305#issuecomment-2465678139 i tried to run the following codes: (multiple processes to `append` to the same iceberg table) ``` import os import time from multiprocessing import Pool

[PR] Docs: Fixes Release Formatting for 1.7.0 Release Notes [iceberg]

RussellSpitzer opened a new pull request, #11499: URL: https://github.com/apache/iceberg/pull/11499 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] Remove Latest Directory [iceberg]

RussellSpitzer opened a new pull request, #11501: URL: https://github.com/apache/iceberg/pull/11501 The directory isn't actually used for anything. The docs creates a symlink to the latest Iceberg release. -- This is an automated message from the Apache Git Service. To respond to the mess

[PR] Docs: Adds Release notes for 1.6.1 [iceberg]

RussellSpitzer opened a new pull request, #11500: URL: https://github.com/apache/iceberg/pull/11500 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] [bug] read from multiple s3 regions [iceberg-python]

danhphan commented on issue #1279: URL: https://github.com/apache/iceberg-python/issues/1279#issuecomment-2466056391 Hey @kevinjqliu, I will happy to work on this task. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Test out Apache Parquet 1.14.4 RC2 [iceberg]

singhpk234 commented on code in PR #11502: URL: https://github.com/apache/iceberg/pull/11502#discussion_r1835280699 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ## @@ -217,27 +217,27 @@ public void testPrimitiveColumns

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

rocco408 commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1835224007 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.NestedFiel

Re: [PR] Flink: Maintenance - RewriteDataFiles [iceberg]

pvary commented on PR #11497: URL: https://github.com/apache/iceberg/pull/11497#issuecomment-2466083244 > Could we break this up into smaller PR's? I think just one for the refactoring of classes out of the Spark Module would be a good first step? Sure thing. I think for these refacto

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835144928 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] chore: upgrade to DataFusion 43 [iceberg-rust]

liurenjie1024 merged PR #691: URL: https://github.com/apache/iceberg-rust/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

sfc-gh-ygu commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1834857267 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -251,13 +253,14 @@ private static Schema fileProjection( Schema tableSchema, S

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1834857507 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate

Re: [PR] Exclude reading _pos column if it's not in the scan list [iceberg]

sfc-gh-ygu commented on code in PR #11390: URL: https://github.com/apache/iceberg/pull/11390#discussion_r1834857267 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -251,13 +253,14 @@ private static Schema fileProjection( Schema tableSchema, S

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1834857507 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -769,6 +794,82 @@ protected void validateDataFilesExist( } } + // validate

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1834587711 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.

Re: [I] [Feature] Provide Nightly Build to PyPi [iceberg-python]

kevinjqliu commented on issue #872: URL: https://github.com/apache/iceberg-python/issues/872#issuecomment-2465443904 @djouallah I'll take another look at the nightly build. But we're in the process of releasing 0.8.0; its in the voting stage https://lists.apache.org/thread/0xcw56z1bpldypm7p

[PR] Boto Glue standard retry policy with configuration [iceberg-python]

mark-major opened a new pull request, #1307: URL: https://github.com/apache/iceberg-python/pull/1307 configurable max retry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Adaptive retry for Glue Catalog calls to fix Glue throttling [iceberg-python]

mark-major commented on issue #1294: URL: https://github.com/apache/iceberg-python/issues/1294#issuecomment-2465469097 PR #1307 is opened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834703801 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] Core: Support DVs in DeleteLoader [iceberg]

aokolnychyi commented on code in PR #11481: URL: https://github.com/apache/iceberg/pull/11481#discussion_r1834763283 ## data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java: ## @@ -259,4 +284,46 @@ private long estimateEqDeletesSize(DeleteFile deleteFile, Schema pro

Re: [PR] Core: Support DVs in DeleteLoader [iceberg]

aokolnychyi merged PR #11481: URL: https://github.com/apache/iceberg/pull/11481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Core: Support DVs in DeleteLoader [iceberg]

aokolnychyi commented on PR #11481: URL: https://github.com/apache/iceberg/pull/11481#issuecomment-2465303918 Thanks for reviewing, @jbonofre @nastra @danielcweeks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Infra: Update DOAP.RDF for Apache Iceberg 1.7.0 [iceberg]

Fokko merged PR #11492: URL: https://github.com/apache/iceberg/pull/11492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Let revapi compare against 1.7.0 [iceberg]

Fokko commented on PR #11490: URL: https://github.com/apache/iceberg/pull/11490#issuecomment-2465556899 Thanks @RussellSpitzer! Let's get those deprecation PRs rebased! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Docs: Site Update for 1.7.0 Release [iceberg]

RussellSpitzer commented on code in PR #11494: URL: https://github.com/apache/iceberg/pull/11494#discussion_r1834919773 ## site/docs/releases.md: ## @@ -72,10 +72,90 @@ To add a dependency on Iceberg in Maven, add the following to your `pom.xml`: ``` +### 1.7.0 release + +

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#issuecomment-2465147688 @liurenjie1024 ready for another round! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834631345 ## crates/iceberg/src/error.rs: ## @@ -44,6 +44,8 @@ pub enum ErrorKind { /// /// This error is returned when given iceberg feature is not supported.

Re: [I] Is `pyiceberg.Table` thread-safe? [iceberg-python]

kevinjqliu commented on issue #1305: URL: https://github.com/apache/iceberg-python/issues/1305#issuecomment-2465274731 the write process rely on the catalog's atomic swap to guarantee serializable isolation. Multiple threads can call `append` but only one will succeed at a time, the others

Re: [PR] Ignore schema merge updates from long -> int [iceberg]

rocco408 commented on code in PR #11419: URL: https://github.com/apache/iceberg/pull/11419#discussion_r1834599748 ## core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java: ## @@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, Types.NestedFiel

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834645491 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834644947 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] feat: Implement TableRequirement checks [iceberg-rust]

c-thiel commented on code in PR #689: URL: https://github.com/apache/iceberg-rust/pull/689#discussion_r1834645951 ## crates/iceberg/src/catalog/mod.rs: ## @@ -453,6 +453,115 @@ impl TableUpdate { } } +impl TableRequirement { +/// Check that the requirement is met by

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834692436 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834696233 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] Add Version Docs for 1.7.0 [iceberg]

RussellSpitzer closed pull request #11493: Add Version Docs for 1.7.0 URL: https://github.com/apache/iceberg/pull/11493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] chore: upgrade to DataFusion 43 [iceberg-rust]

gruuya opened a new pull request, #691: URL: https://github.com/apache/iceberg-rust/pull/691 The sole code change here is that `Debug` is a new trait bound for a lot of DataFusion traits now: https://github.com/apache/datafusion/issues/12555. -- This is an automated message from the Apach

Re: [PR] Remove Latest Directory [iceberg]

Fokko merged PR #11501: URL: https://github.com/apache/iceberg/pull/11501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Docs: Adds Release notes for 1.6.1 [iceberg]

Fokko merged PR #11500: URL: https://github.com/apache/iceberg/pull/11500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Docs: Fixes Release Formatting for 1.7.0 Release Notes [iceberg]

RussellSpitzer commented on PR #11499: URL: https://github.com/apache/iceberg/pull/11499#issuecomment-2465728599 Yep I should have had my preview window on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Docs: Fixes Release Formatting for 1.7.0 Release Notes [iceberg]

Fokko merged PR #11499: URL: https://github.com/apache/iceberg/pull/11499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[PR] Test out Apache Parquet 1.14.4 [iceberg]

Fokko opened a new pull request, #11502: URL: https://github.com/apache/iceberg/pull/11502 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Enhance `catalog.create_table` API to enable creation of table with matching `field_ids` to provided Schema [iceberg-python]

sungwy commented on issue #1284: URL: https://github.com/apache/iceberg-python/issues/1284#issuecomment-2465872766 I just put up this PR to introduce a new flag `assign_fresh_ids` on `create_table` and related methods. > Keep in mind that the REST catalog also might re-assign IDs (I

Re: [PR] Relax client.credentials-provider requirements [iceberg]

morozov commented on PR #10604: URL: https://github.com/apache/iceberg/pull/10604#issuecomment-2465871993 This PR still requires a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Spark 3.5: Iceberg parser should passthrough unsupported procedure to delegate [iceberg]

RussellSpitzer commented on code in PR #11480: URL: https://github.com/apache/iceberg/pull/11480#discussion_r1835134116 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala: ## @@ -151,6 +155,11 @@ cl

Re: [PR] Spark 3.5: Iceberg parser should passthrough unsupported procedure to delegate [iceberg]

RussellSpitzer commented on code in PR #11480: URL: https://github.com/apache/iceberg/pull/11480#discussion_r1835133846 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/SparkProcedures.java: ## @@ -37,6 +38,10 @@ public static ProcedureBuilder newBuilder(Str

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835144928 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835147603 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

Re: [PR] Core: Support commits with DVs [iceberg]

aokolnychyi commented on code in PR #11495: URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835152614 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) { /** Add a delete fil

  1   2   >