aokolnychyi commented on code in PR #11495:
URL: https://github.com/apache/iceberg/pull/11495#discussion_r1835114428
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -245,13 +250,13 @@ private PartitionSpec spec(int specId) {
/** Add a delete file to the new snapshot. */
protected void add(DeleteFile file) {
- Preconditions.checkNotNull(file, "Invalid delete file: null");
+ validateNewDeleteFile(file);
add(new PendingDeleteFile(file));
}
/** Add a delete file to the new snapshot. */
protected void add(DeleteFile file, long dataSequenceNumber) {
- Preconditions.checkNotNull(file, "Invalid delete file: null");
+ validateNewDeleteFile(file);
Review Comment:
This only affects new delete files that are added to the table. I had a test
in the prototype PR that verified that automatic manifest compaction after
upgrading to V3 didn't have issues. Let me check if I added that test to this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
