rocco408 commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1835224007


##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field, 
Types.NestedField existingFie
     }
   }
 
+  private boolean ignorableUpdate(Type newType, Type existingType) {
+    if (newType.isPrimitiveType()) {
+      if (newType.equals(existingType)) {
+        return true;
+      }
+      if (existingType.typeId() == Type.TypeID.LONG && newType.typeId() == 
Type.TypeID.INTEGER) {

Review Comment:
   Thank you @RussellSpitzer and @huaxingao, I pulled in those changes 🙇 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to