RussellSpitzer commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1835074284
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field,
Types.NestedField existingFie
}
}
+ private boolean ignorableUpdate(Type newType, Type existingType) {
+ if (newType.isPrimitiveType()) {
+ if (newType.equals(existingType)) {
+ return true;
+ }
+ if (existingType.typeId() == Type.TypeID.LONG && newType.typeId() ==
Type.TypeID.INTEGER) {
Review Comment:
https://github.com/rocco408/iceberg/pull/1/files - Futzed around with this
and I think this may be cleaner. I ended up renegating the function and used a
switch statement. When I think about adding the decimal case, this seems like
it will be cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
