sfc-gh-ygu commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1834857267
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -251,13 +253,14 @@ private static Schema fileProjection(
Schema tableSchema,
Schema requestedSchema,
List<DeleteFile> posDeletes,
- List<DeleteFile> eqDeletes) {
+ List<DeleteFile> eqDeletes,
+ boolean needRowPosCol) {
if (posDeletes.isEmpty() && eqDeletes.isEmpty()) {
return requestedSchema;
}
Set<Integer> requiredIds = Sets.newLinkedHashSet();
- if (!posDeletes.isEmpty()) {
+ if (!posDeletes.isEmpty() && needRowPosCol) {
Review Comment:
Nit: switch two condition to make it more readable.
```
if (needRowPosCol && !posDeletes.isEmpty()) {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
