flyrain commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1830093248
##########
.palantir/revapi.yml:
##########
@@ -1145,6 +1145,15 @@ acceptedBreaks:
new: "method org.apache.iceberg.BaseMetastoreOperations.CommitStatus
org.apache.iceberg.BaseMetastoreTableOperations::checkCommitStatus(java.lang.String,\
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
+ org.apache.iceberg:iceberg-data:
+ - code: "java.method.numberOfParametersChanged"
+ old: "method void
org.apache.iceberg.data.DeleteFilter<T>::<init>(java.lang.String,\
+ \ java.util.List<org.apache.iceberg.DeleteFile>,
org.apache.iceberg.Schema,\
+ \ org.apache.iceberg.Schema, org.apache.iceberg.deletes.DeleteCounter)"
+ new: "method void
org.apache.iceberg.data.DeleteFilter<T>::<init>(java.lang.String,\
+ \ java.util.List<org.apache.iceberg.DeleteFile>,
org.apache.iceberg.Schema,\
+ \ org.apache.iceberg.Schema, org.apache.iceberg.deletes.DeleteCounter,
boolean)"
+ justification: "add a param to tell if the pos column needs to ve
included"
Review Comment:
ve -> be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
