RussellSpitzer commented on code in PR #11480:
URL: https://github.com/apache/iceberg/pull/11480#discussion_r1835134116
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -151,6 +155,11 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface) extends ParserI
isSnapshotRefDdl(normalized)))
}
+ private def isIcebergProcedure(normalized: String): Boolean = {
+ // All builtin Iceberg procedures are under the 'system' namespace
+ SparkProcedures.names().asScala.map("system." +
_).exists(normalized.contains)
Review Comment:
Ok got it, so Normalized is actually normalizedSql. My confusion is that
this checks only for 50% of the proof that it is an Iceberg Procedure with the
"call" check happening outside the function.
I would think we would want
```java
isIcebergProcedure(normalized: String) {
normalized.startsWith("call") &&
SparkProcedures.names().asScala.map("system." +
_).exists(normalized.contains)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
