singhpk234 commented on code in PR #11502:
URL: https://github.com/apache/iceberg/pull/11502#discussion_r1835280699
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##########
@@ -217,27 +217,27 @@ public void testPrimitiveColumns() throws Exception {
Row binaryCol =
Row.of(
- 52L,
+ 55L,
4L,
2L,
null,
Base64.getDecoder().decode("1111"),
Base64.getDecoder().decode("2222"));
- Row booleanCol = Row.of(32L, 4L, 0L, null, false, true);
- Row decimalCol = Row.of(85L, 4L, 1L, null, new BigDecimal("1.00"), new
BigDecimal("2.00"));
- Row doubleCol = Row.of(85L, 4L, 0L, 1L, 1.0D, 2.0D);
+ Row booleanCol = Row.of(36L, 4L, 0L, null, false, true);
+ Row decimalCol = Row.of(91L, 4L, 1L, null, new BigDecimal("1.00"), new
BigDecimal("2.00"));
+ Row doubleCol = Row.of(91L, 4L, 0L, 1L, 1.0D, 2.0D);
Review Comment:
[optional] should we refactor this to pick file_size from the Datafiles
themselve like we did we did in JDK 17 upgrade PR
https://github.com/apache/iceberg/pull/7391#discussion_r1173288917
Never the less looks like size in bytes is increasing in this version is it
because they are more accurate now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
