liurenjie1024 commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2510452060
> @ZENOTME thanks for getting back to me here. I don't want to be the one
holding this up, so I would suggest that we get this in. There are still some
gaps I see because I think
liurenjie1024 commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1865150243
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +172,365 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast ap
Fokko merged PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2503865388
@ZENOTME thanks for getting back to me here. I don't want to be the one
holding this up, so I would suggest that we get this in. There are still some
gaps I see because I think it is pre
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2503852172
> @ZENOTME I think you're on Linux? I'm on Mac, and I think the docker
networking is different.
>
> First I have to change the networking quite a bit, because the loop that
wait
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860543850
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860405562
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860405562
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860359778
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860342931
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860337732
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860331145
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +172,364 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860328978
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
Fokko commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2503385681
@ZENOTME I think you're on Linux? I'm on Mac, and I think the docker
networking is different.
First I have to change the networking quite a bit, because the loop that
waits for th
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860256574
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +172,364 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860178688
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860177985
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860174591
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860112766
##
crates/iceberg/src/transaction.rs:
##
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+fn generate_unique_snapshot_id(&self) -> i64 {
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860102313
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -106,34 +106,38 @@ impl std::fmt::Debug for ManifestListWriter {
impl ManifestListWriter {
/// Construct a v
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860074706
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -106,34 +106,38 @@ impl std::fmt::Debug for ManifestListWriter {
impl ManifestListWriter {
/// Construct a v
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860068128
##
crates/e2e_test/Cargo.toml:
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NO
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1855708285
##
crates/iceberg/src/transaction.rs:
##
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+fn generate_unique_snapshot_id(&self) -> i64
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1855695281
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1855684639
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1855682480
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,383 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1854528111
##
crates/iceberg/src/spec/manifest_list.rs:
##
@@ -106,34 +106,38 @@ impl std::fmt::Debug for ManifestListWriter {
impl ManifestListWriter {
/// Construct a
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1852590840
##
crates/iceberg/src/transaction.rs:
##
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+fn generate_unique_snapshot_id(&self) -> i64
c-thiel commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1852078486
##
crates/e2e_test/Cargo.toml:
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2487346035
> @ZENOTME Thanks, `make test` also runs successfully for me. I'm pretty
sure that the test works, but I want to assert certain things on the metadata.
Having the IDE to set breakpoint
Fokko commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2485342410
@ZENOTME Thanks, `make test` also runs successfully for me. I'm pretty sure
that the test works, but I want to assert certain things on the metadata.
Having the IDE to set breakpoints ma
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847922844
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1328,7 +1334,7 @@ mod _serde {
Ok(Self {
content: value.content as i32,
f
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847748258
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1328,7 +1334,7 @@ mod _serde {
Ok(Self {
content: value.content as i32,
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2484580413
> @ZENOTME Are you able to run the tests from your IDE?
>
> When running from RustRover, the test is stuck on starting the containers.
When I change the code to exclude the start
Fokko commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2484102346
@ZENOTME Are you able to run the tests from your IDE?
When running from RustRover, the test is stuck on starting the containers.
When I change the code to exclude the starting of t
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847225254
##
crates/e2e_test/tests/conflict_commit_test.rs:
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847168059
##
crates/iceberg/src/transaction.rs:
##
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+fn generate_unique_snapshot_id(&self) -> i64 {
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847167614
##
crates/iceberg/src/transaction.rs:
##
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+fn generate_unique_snapshot_id(&self) -> i64 {
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2483287118
> @ZENOTME Sorry for leaving this hanging for so long, I'll do another pass
today. I wanted to do it, but running into some issues with RustRover. I have
to step out for some other iss
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1846727927
##
crates/e2e_test/tests/conflict_commit_test.rs:
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2483245755
@ZENOTME Sorry for leaving this hanging for so long, I'll do another pass
today. I wanted to do it, but running into some issues with RustRover. I have
to step out for some other issues,
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1846645067
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,387 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1846625846
##
crates/e2e_test/tests/conflict_commit_test.rs:
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1846624096
##
crates/e2e_test/tests/conflict_commit_test.rs:
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1844241268
##
crates/iceberg/src/transaction.rs:
##
@@ -122,6 +189,387 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2477887517
Hi, I think this PR has been blocked for a long time. Recently AFAIK there
have been some users who want to get write ability. Can we make progress on
this? cc @Fokko @liurenjie1024 @
ZENOTME commented on PR #696:
URL: https://github.com/apache/iceberg-rust/pull/696#issuecomment-2475882857
Sorry, Please ignore this mistake operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
ZENOTME closed pull request #696: feat: support append data file and add e2e
test
URL: https://github.com/apache/iceberg-rust/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1841846043
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,234 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2376706216
> We're introducing a lot of new concepts here and generate a lot of open
end (snapshot summary generation, metrics collection, schema compatibility
checks, etc). I think it would be b
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611289703
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match schem
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611285227
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,234 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611283989
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +190,313 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611275943
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611273092
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +190,313 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611265301
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611264064
##
crates/iceberg/src/spec/datatypes.rs:
##
@@ -260,6 +279,29 @@ impl<'de> Deserialize<'de> for PrimitiveType {
}
}
+impl PrimitiveType {
+/// Check whethe
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611263732
##
crates/iceberg/src/spec/datatypes.rs:
##
@@ -260,6 +279,29 @@ impl<'de> Deserialize<'de> for PrimitiveType {
}
}
+impl PrimitiveType {
+/// Check whethe
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611261437
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611259929
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match schem
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611247468
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611244871
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611236654
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2108162712
Hi, I have tried to fix this PR. Some things may not be fixed well now:
1. https://github.com/apache/iceberg-rust/pull/349#discussion_r1580444775
I'm not sure whether my understa
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1598744515
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1598713751
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1595472104
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
marvinlanhenke commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1582058099
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580571634
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match sch
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580446821
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580444775
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579520268
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579472707
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579466191
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579449633
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579449633
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579426812
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579420662
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579412576
##
crates/iceberg/src/transaction.rs:
##
@@ -95,6 +104,42 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+/// Creates a fast append action.
+pub fn f
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579406252
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579402269
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579401733
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agr
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579401183
##
crates/e2e_test/tests/append_data_file_test.rs:
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579375646
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579372414
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579369755
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579368639
##
crates/e2e_test/testdata/docker-compose.yaml:
##
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579004695
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match schem
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1579004695
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match schem
Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1578992843
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append dat
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1578812779
##
crates/iceberg/src/transaction.rs:
##
@@ -121,6 +166,270 @@ impl<'a> Transaction<'a> {
}
}
+/// FastAppendAction is a transaction action for fast append d
ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1578811481
##
crates/iceberg/src/io.rs:
##
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match sch
ZENOTME commented on PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2076295905
cc @liurenjie1024 @Fokko @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
93 matches
Mail list logo
