Fokko commented on code in PR #349: URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847922844
########## crates/iceberg/src/spec/manifest.rs: ########## @@ -1328,7 +1334,7 @@ mod _serde { Ok(Self { content: value.content as i32, file_path: value.file_path, - file_format: value.file_format.to_string(), + file_format: value.file_format.to_string().to_ascii_uppercase(), Review Comment: Good catch, I've created an issue to get that fixed: https://github.com/apache/iceberg-python/issues/1340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org