ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1580571634
##########
crates/iceberg/src/io.rs:
##########
@@ -368,6 +368,9 @@ impl Storage {
new_props.insert("root".to_string(), DEFAULT_ROOT_PATH.to_string());
match scheme {
+ Scheme::Memory => Ok(Self::LocalFs {
Review Comment:
> inherently you're testing a different path than it would normally would.
Yes, but we only limit it to the storage layer. It can provide a writable
mock layer for unit tests which can make us test the process logic and internal
state in units easier. Otherwise, we only can test this in e2e test. And the
problem with e2e test is that we can't check the internal state. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
