ZENOTME commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1847748258
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1328,7 +1334,7 @@ mod _serde {
Ok(Self {
content: value.content as i32,
file_path: value.file_path,
- file_format: value.file_format.to_string(),
+ file_format:
value.file_format.to_string().to_ascii_uppercase(),
Review Comment:
Pyiceberg fail to read if this file format is not uppercase. BTW, we can add
test using pyiceberg to ensure the write is valid for other SDK later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
