Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1860112766
##########
crates/iceberg/src/transaction.rs:
##########
@@ -96,6 +109,60 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+ fn generate_unique_snapshot_id(&self) -> i64 {
+ let generate_random_id = || -> i64 {
+ let (lhs, rhs) = Uuid::new_v4().as_u64_pair();
+ let snapshot_id = (lhs ^ rhs) as i64;
+ if snapshot_id < 0 {
+ -snapshot_id
+ } else {
+ snapshot_id
+ }
+ };
+ let mut snapshot_id = generate_random_id();
+ while self
+ .table
+ .metadata()
+ .snapshots()
+ .any(|s| s.snapshot_id() == snapshot_id)
+ {
+ snapshot_id = generate_random_id();
+ }
+ snapshot_id
+ }
+
+ /// Creates a fast append action.
+ pub fn fast_append(
+ self,
+ commit_uuid: Option<Uuid>,
+ key_metadata: Vec<u8>,
+ ) -> Result<FastAppendAction<'a>> {
+ let parent_snapshot_id = self
+ .table
+ .metadata()
+ .current_snapshot()
+ .map(|s| s.snapshot_id());
+ let snapshot_id = self.generate_unique_snapshot_id();
+ let schema = self.table.metadata().current_schema().as_ref().clone();
+ let schema_id = schema.schema_id();
+ let format_version = self.table.metadata().format_version();
+ let partition_spec =
self.table.metadata().default_partition_spec().clone();
+ let commit_uuid = commit_uuid.unwrap_or_else(Uuid::new_v4);
Review Comment:
I don't think this is mentioned in the spec, I think V7 is fine as well, as
it randomizes much better. See
https://materializedview.io/i/142011675/uuid-shootout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
