liurenjie1024 commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1986860460
> > > It would also be good to assert if they are there.
>
> >
>
> > Sorry, I'm not sure what this means. Did you mean assert like following?
>
> >
>
liurenjie1024 merged PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1986854100
> > It would also be good to assert if they are there.
>
> Sorry, I'm not sure what this means. Did you mean assert like following?
>
> ```
> let schema = ...;
> asse
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1986843681
> cc @ZENOTME Would you mind to fix the conflicts?
Sorry, don't notice it before. I fix it now.
--
This is an automated message from the Apache Git Service.
To respond to the m
liurenjie1024 commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1986843324
cc @ZENOTME Would you mind to fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1509234137
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,594 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
Fokko commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1508929875
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,594 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1972533382
I have added more tests. Feel free to tell me if there is still something
need to improve. @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the mess
Fokko commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1507992831
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
liurenjie1024 commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1970342629
> My personal approach is to develop a simple, functional API that meets the
required features and then build upon it. Having a powerful API from the start
makes me nervous. Addi
Xuanwo commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1970337631
> For here, I just find that this design can give users more power to custom
and reuse something so I follow it. It's ok for me to modify it if there is a
simpler design.
Thank y
liurenjie1024 commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1970336526
> I still question whether following Java's API is a good idea. I believe we
can create a better and more user-friendly API for rust users.
In fact this is not end user api
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1970332953
> I still question whether following Java's API is a good idea. I believe we
can create a better and more user-friendly API for rust users.
>
> However, this shouldn't hold us ba
liurenjie1024 commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1970299150
cc @Xuanwo Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492447476
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492450927
##
crates/iceberg/src/writer/file_writer/track_writer.rs:
##
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492447476
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492446872
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492445165
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492439815
##
crates/iceberg/src/io.rs:
##
@@ -240,9 +241,9 @@ impl InputFile {
}
/// Trait for writing file.
-pub trait FileWrite: AsyncWrite {}
+pub trait FileWrite: Async
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492434129
##
crates/iceberg/src/io.rs:
##
@@ -240,9 +241,9 @@ impl InputFile {
}
/// Trait for writing file.
-pub trait FileWrite: AsyncWrite {}
+pub trait FileWrite: Asyn
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1483994701
##
crates/iceberg/src/io.rs:
##
@@ -240,9 +241,9 @@ impl InputFile {
}
/// Trait for writing file.
-pub trait FileWrite: AsyncWrite {}
+pub trait FileWrite: Async
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1928766039
I think this writer is ready to go now. PTAL @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1477719264
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1477655462
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1477651653
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1477561649
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1476988389
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -18,16 +18,20 @@
//! This module contains the writer for data file format supported by iceberg:
parquet, orc
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1476921216
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -18,16 +18,20 @@
//! This module contains the writer for data file format supported by iceberg:
parque
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475773886
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475772911
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) -> Result
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475635301
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475621034
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475596750
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475593785
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475592171
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475583716
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475581238
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,390 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475578608
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475452336
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,390 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475451458
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,390 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475447615
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,390 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475446762
##
crates/iceberg/src/writer/file_writer/location_generator.rs:
##
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1475440018
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1473864622
##
crates/iceberg/src/error.rs:
##
@@ -44,6 +44,9 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470792480
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -924,7 +924,7 @@ impl TryFrom for ManifestStatus {
}
/// Data file carries data file path, partition tuple, m
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470721802
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470721802
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470712134
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470677827
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470676713
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470675094
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470672780
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470668094
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) -> Result
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470665655
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) -> Result<
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470664532
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -924,7 +924,7 @@ impl TryFrom for ManifestStatus {
}
/// Data file carries data file path, partition tuple, metrics
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470664109
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) ->
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470662411
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) -> Result
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470648930
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
Review Comment:
Sounds reasonable, we already have avro included, so it makes sense to
inc
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470626858
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470626858
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470626858
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
+
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470624504
##
crates/iceberg/src/io.rs:
##
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+/// Delete file.
+pub async fn delete(&self) -> Result<
Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470623846
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
Review Comment:
The files supported by iceberg are limited, which is not as extensive as
catalogs
liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470518241
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
Review Comment:
I'm thinking moving this to another crate `iceberg-parquet`, the core crate
ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1469148875
##
crates/iceberg/src/io.rs:
##
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
-pub async fn writer(&self) -> Result {
66 matches
Mail list logo
