ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470664532
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -924,7 +924,7 @@ impl TryFrom<i32> for ManifestStatus {
}
/// Data file carries data file path, partition tuple, metrics, …
-#[derive(Debug, PartialEq, Clone, Eq, TypedBuilder)]
+#[derive(Debug, PartialEq, Clone, Eq, Builder)]
Review Comment:
Because I find that we need to return the Builder type, if we use
`TypedBuilder`, we can't use `fn close(&self) -> Vec<Builder>` in trait,
because the real return type maybe
`
fn close(&self) -> Vec<Builder<...>>
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
