liurenjie1024 commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1476921216
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -18,16 +18,20 @@
//! This module contains the writer for data file format supported by iceberg:
parquet, orc.
use super::{CurrentFileStatus, DefaultOutput};
-use crate::Result;
+use crate::{io::OutputFile, Result};
use arrow_array::RecordBatch;
use futures::Future;
+mod parquet_writer;
+pub use parquet_writer::{ParquetWriter, ParquetWriterBuilder};
+mod track_writer;
+
/// File writer builder trait.
pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static {
/// The associated file writer type.
type R: FileWriter<O>;
/// Build file writer.
- fn build(self) -> impl Future<Output = Result<Self::R>> + Send;
+ fn build(self, out_file: OutputFile) -> impl Future<Output =
Result<Self::R>> + Send;
Review Comment:
Why we need to change the interface? As we discussed, why not put `FileIO`
in builder? I guess this will not work for `RollingFileWriterBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
