Xuanwo commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470665655
##########
crates/iceberg/src/io.rs:
##########
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+ /// Delete file.
+ pub async fn delete(&self) -> Result<()> {
Review Comment:
> Does [writer in
opendal](https://docs.rs/opendal/latest/opendal/struct.Operator.html?search=writer#method.writer)
create the file?
It depends. AFAIK, opendal on s3 won't create file unless `close` has
returned `Ok()`.
By the way, the use case you mentioned here more like
[`Writer::abort`](https://opendal.apache.org/docs/rust/opendal/struct.Writer.html#method.abort).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
