liurenjie1024 commented on PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1986860460
> > > It would also be good to assert if they are there. > > > > > > Sorry, I'm not sure what this means. Did you mean assert like following? > > > > > > ``` > > > let schema = ...; > > > assert_eq(schema.fields[0].metadata().get(field_id),1); > > > ``` > > > > I have fixed it now. How about merging it first and refining the test later? After merging it, we can continue the writer's work. Sounds reasonable to me, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
