ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1492434129
##########
crates/iceberg/src/io.rs:
##########
@@ -240,9 +241,9 @@ impl InputFile {
}
/// Trait for writing file.
-pub trait FileWrite: AsyncWrite {}
+pub trait FileWrite: AsyncWrite + TokioAsyncWrite + Send + Unpin {}
Review Comment:
I added TokioAsyncWrite because the parquet writer accepct a tokio writer.
Can we remove the futures::AsyncWrite? Since for now, we don't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
