ZENOTME commented on code in PR #176: URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1477655462
########## crates/iceberg/src/writer/file_writer/location_generator.rs: ########## @@ -0,0 +1,108 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains the location generator and file name generator for generating path of data file. + +use std::sync::{atomic::AtomicU64, Arc}; + +/// `LocationGenerator` used to generate the location of data file. +pub trait LocationGenerator: Clone + Send + 'static { + /// Generate a absolute path for the given file name. + /// e.g + /// For file name "part-00000.parquet", the generated location maybe "/table/data/part-00000.parquet" + fn generate_location(&self, file_name: &str) -> String; Review Comment: The reason why iceberg-java need this parameter is that the design of iceberg-java is to pass the `OutPutFile` to lower level writer. So that it need to generate the file path to lower level writer and the file path may have different partition dir. But in our design, we let the lower level writer generate the `OutPutFile` using `FileIO` and `LocationGenerator` by itself. So I find that we can just use a LocationGenerator bind with a partition value, like ``` struct PartitionLocationGenerator { dir: String } impl PartitionLocationGenerator { pub fn new(partition_value: Value) -> Self } ``` And do not need to use partition_value parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
