Re: [PR] Core: Make namespace separator configurable [iceberg]

github-actions[bot] commented on PR #10877: URL: https://github.com/apache/iceberg/pull/10877#issuecomment-2475083883 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1799108419 ## open-api/rest-catalog-open-api.yaml: ## @@ -1747,7 +1749,9 @@ components: required: true description: A namespace identifier as a single stri

Re: [PR] Core: Make namespace separator configurable [iceberg]

cwsteinbach commented on PR #10877: URL: https://github.com/apache/iceberg/pull/10877#issuecomment-2407829882 @nastra, can you please update the description field to explain why this change is necessary? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Core: Make namespace separator configurable [iceberg]

cwsteinbach commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1797223415 ## open-api/rest-catalog-open-api.yaml: ## @@ -1747,7 +1749,9 @@ components: required: true description: A namespace identifier as a single

Re: [PR] Core: Make namespace separator configurable [iceberg]

cwsteinbach commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1797223185 ## open-api/rest-catalog-open-api.yaml: ## @@ -261,7 +261,9 @@ paths: description: An optional namespace, underneath which to list namespa

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1724675149 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

jackye1995 commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1722436641 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encod

Re: [PR] Core: Make namespace separator configurable [iceberg]

jackye1995 commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1722436641 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encod

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1720947546 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1720944857 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

jackye1995 commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1720032100 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encod

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1719970410 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1715268640 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1715236730 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on PR #10877: URL: https://github.com/apache/iceberg/pull/10877#issuecomment-2285913919 > I still have concerns about this PR. Some of the concerns have been proactively resolved with "this is copy-paste". I'm not sure whether this comes from a misunderstanding of the

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1715057335 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1715001338 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714992568 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on PR #10877: URL: https://github.com/apache/iceberg/pull/10877#issuecomment-2285678621 This PR and the mentioned follow-ups change the REST spec. It seems to be agreed on, that all specification changes require a code-change vote on the dev mailing list. -- This is an au

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714883557 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714882063 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714878668 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded st

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714877056 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded st

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on PR #10877: URL: https://github.com/apache/iceberg/pull/10877#issuecomment-2285442828 @jackye1995 could you take a look at this PR please? It would be great to get this in, so that we can can continue with https://github.com/apache/iceberg/pull/10904 / https://github.com

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711679815 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711677062 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711532749 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711532749 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711532266 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711530996 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711529328 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711528454 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1711255861 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded st

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710837520 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710821112 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710818707 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -73,6 +73,7 @@ /** Adaptor class to translate REST requests into {@link Catalog} API call

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710818461 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -665,7 +670,7 @@ public static void configureResponseFromException( } private stat

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710816282 ## core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java: ## @@ -67,18 +70,24 @@ public void testStripTrailingSlash() { } } - @Test - public void te

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710802860 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710800461 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1710798023 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709913592 ## core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java: ## @@ -67,18 +70,24 @@ public void testStripTrailingSlash() { } } - @Test - public void te

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709908764 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -665,7 +670,7 @@ public static void configureResponseFromException( } private stat

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709907532 ## core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java: ## @@ -73,6 +73,7 @@ /** Adaptor class to translate REST requests into {@link Catalog} API call

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709904764 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709903381 ## core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java: ## @@ -40,39 +46,48 @@ public static String tokens() { } private final String prefix; + priv

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709887786 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709885848 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,33 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709883660 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -194,15 +192,34 @@ public static String decodeString(String encoded) { * @return UTF-8 encoded s

Re: [PR] Core: Make namespace separator configurable [iceberg]

rdblue commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709881402 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709702079 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709694414 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709690499 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709688072 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709686056 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709686056 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709683024 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709683024 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,10 @@ paths: description: An optional namespace, underneath which to list namespaces

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709636484 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,8 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709634646 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,8 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709526128 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,8 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

dimas-b commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709441061 ## open-api/rest-catalog-open-api.yaml: ## @@ -222,7 +222,8 @@ paths: description: An optional namespace, underneath which to list namespaces.

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1705174451 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1705142884 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -116,6 +116,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog privat

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1705139878 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,26 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace

Re: [PR] Core: Make namespace separator configurable [iceberg]

amogh-jahagirdar commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1704687240 ## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ## @@ -215,8 +232,26 @@ public static String encodeNamespace(Namespace ns) { * @return a nam

Re: [PR] Core: Make namespace separator configurable [iceberg]

nastra closed pull request #10877: Core: Make namespace separator configurable URL: https://github.com/apache/iceberg/pull/10877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.