snazy commented on code in PR #10877: URL: https://github.com/apache/iceberg/pull/10877#discussion_r1714882063
########## core/src/main/java/org/apache/iceberg/rest/RESTUtil.java: ########## @@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) { * @return a namespace */ public static Namespace decodeNamespace(String encodedNs) { - Preconditions.checkArgument(encodedNs != null, "Invalid namespace: null"); - String[] levels = Iterables.toArray(NAMESPACE_ESCAPED_SPLITTER.split(encodedNs), String.class); + return decodeNamespace(encodedNs, NAMESPACE_ESCAPED_SEPARATOR); + } + + /** + * Takes in a string representation of a namespace as used for a URL parameter and returns the + * corresponding namespace. + * + * <p>See also {@link #encodeNamespace} for generating correctly formatted URLs. + * + * @param encodedNamespace a namespace to decode + * @param separator The namespace separator to use for decoding. This should be the same separator Review Comment: There's no validation then and users can specify everything? No definition & verification of whether this is a single (1 byte) UTF-8 character. No definition & verification of whether this character is URL-encoded or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org