nastra commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1715268640
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -215,8 +232,32 @@ public static String encodeNamespace(Namespace ns) {
* @return a namespace
*/
public static Namespace decodeNamespace(String encodedNs) {
Review Comment:
I don't think that argument is actually true. **Users** won't be using this
code as this code is used on the client and the server but not by **users** in
the classical sense of a user that uses Iceberg. For engine/catalog
implementers the javadoc states that one should have used
`encodeNamespace(Namespace namespace)` if you use `decodeNamespace(String
encodedNs)`.
Using words like `dangerous` and `confusing` without clear examples and
justifications isn't helpful in a code review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
