dimas-b commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r1709683024
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -222,7 +222,10 @@ paths:
description:
An optional namespace, underneath which to list namespaces.
If not provided or empty, all top-level namespaces should be
listed.
- If parent is a multipart namespace, the parts must be separated by
the unit separator (`0x1F`) byte.
+ If parent is a multipart namespace, the parts should be separated
by the namespace separator as
+ indicated via the /config override `rest-namespace-separator`,
which defaults to the unit separator (`0x1F`) byte.
+ To be compatible with older clients, servers have to use `0x1F` as
a fallback even when advertising a different
+ namespace separator to clients.
Review Comment:
Thanks for the update @nastra . Sorry to be nit-picky, but I believe this
text is still not clear enough. I'd suggest `To be compatible with older
clients, servers should use both the advertised separator and 0x1F as a valid
separators when parsing namespaces.` (feel free to edit)
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -222,7 +222,10 @@ paths:
description:
An optional namespace, underneath which to list namespaces.
If not provided or empty, all top-level namespaces should be
listed.
- If parent is a multipart namespace, the parts must be separated by
the unit separator (`0x1F`) byte.
+ If parent is a multipart namespace, the parts should be separated
by the namespace separator as
+ indicated via the /config override `rest-namespace-separator`,
which defaults to the unit separator (`0x1F`) byte.
+ To be compatible with older clients, servers have to use `0x1F` as
a fallback even when advertising a different
+ namespace separator to clients.
Review Comment:
Thanks for the update @nastra . Sorry to be nit-picky, but I believe this
text is still not clear enough. I'd suggest `To be compatible with older
clients, servers should use both the advertised separator and 0x1F as valid
separators when parsing namespaces.` (feel free to edit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
