findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2251300646
thanks for the merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
nastra merged PR #10474:
URL: https://github.com/apache/iceberg/pull/10474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2250236029
thanks for working on this @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1690284578
##
spark/v3.3/build.gradle:
##
@@ -59,6 +59,10 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
implementation project(':iceber
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1688002229
##
spark/v3.3/build.gradle:
##
@@ -59,6 +59,10 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
implementation project(':iceberg
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1673871100
##
baseline.gradle:
##
@@ -46,7 +46,13 @@ subprojects {
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.palantir.baseline-release-com
findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2220510049
Since spotless plugin is not installed on JDK 21, ./gradlew spotlessApply
would fail with
```
$ JAVA_HOME=~/.jenv/versions/21 ./gradlew spotlessApply
FAILURE: Build fail
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1670539963
##
.github/workflows/spark-ci.yml:
##
@@ -69,9 +69,15 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
-jvm: [8, 11, 17]
+jvm: [8, 11
pan3793 commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1670453403
##
.github/workflows/spark-ci.yml:
##
@@ -69,9 +69,15 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
-jvm: [8, 11, 17]
+jvm: [8, 11
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661073834
##
baseline.gradle:
##
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependen
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661056194
##
baseline.gradle:
##
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependen
jbonofre commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661040951
##
baseline.gradle:
##
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-depend
jbonofre commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661062567
##
baseline.gradle:
##
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-depend
jbonofre commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2175532753
@findepi thanks. FYI, I'm fixing the `gradle-revapi` plugin and Ed and I
will do the release, then, I will rebase the Gradle 8.8 PR and we are good 😄
--
This is an automated message
findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2175527255
https://github.com/apache/iceberg/pull/10477,
https://github.com/apache/iceberg/pull/10482,
https://github.com/apache/iceberg/pull/10485 were extracted from here. Will
rebase this PR o
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1641073768
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/j
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1640996276
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/ja
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1640228930
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/j
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639894786
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/ja
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639613179
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##
@@ -531,7 +531,8 @@ private int metadataFileCount(TableMetadata metadata
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639612184
##
.github/workflows/api-binary-compatibility.yml:
##
@@ -27,6 +27,9 @@ on:
- 'apache-iceberg-**'
pull_request:
paths:
+ - '.github/**'
Review Co
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639609595
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/j
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639601901
##
gradle/wrapper/gradle-wrapper.properties:
##
@@ -1,8 +1,8 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
# checksum was taken from https://
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639515485
##
.github/workflows/api-binary-compatibility.yml:
##
@@ -27,6 +27,9 @@ on:
- 'apache-iceberg-**'
pull_request:
paths:
+ - '.github/**'
Review Com
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639515154
##
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##
@@ -531,7 +531,8 @@ private int metadataFileCount(TableMetadata metadata)
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639514171
##
baseline.gradle:
##
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/ja
nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639512270
##
gradle/wrapper/gradle-wrapper.properties:
##
@@ -1,8 +1,8 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
# checksum was taken from https://g
szehon-ho commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2166466182
others here are more familiar with the build than I am, will let them
comment. Is this removing some java version?
Also, why all the code formatting, can we remove those from t
findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2166580206
> others here are more familiar with the build than I am, will let them
comment. Is this removing some java version?
no, i don't think so
> Also, why all the code formattin
jbonofre commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2165897342
@findepi thanks for the PR. As you know, I'm working on revapi and gradle
update.
Supporting JDK21 is great, but we might need to keep previous Java version
for some engine/plug
findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2161509523
cc @rdblue @szehon-ho @Fokko @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
findepi commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2161508864
The build is green, ready for review, but still blocked by
https://github.com/apache/iceberg/issues/10368#issuecomment-2161039351.
Therefore keeping as a draft.
--
This is an automat
findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1633492995
##
gradle/wrapper/gradle-wrapper.properties:
##
@@ -1,8 +1,8 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
# checksum was taken from https://
findepi opened a new pull request, #10474:
URL: https://github.com/apache/iceberg/pull/10474
This is currently the latest Java LTS version, so we should support
building with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
34 matches
Mail list logo
