findepi commented on code in PR #10474: URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639612184
########## .github/workflows/api-binary-compatibility.yml: ########## @@ -27,6 +27,9 @@ on: - 'apache-iceberg-**' pull_request: paths: + - '.github/**' Review Comment: it's also extracted as https://github.com/apache/iceberg/pull/10485, see rationale there. this PR changes build system (gradle version) and it would not be smart to assume workflows continue to work without running them Of course, this doesn't prevent all problems -- revapi silently not working is a type of problem this doesn't prevent -- but at least prevents some and in that sense it is related to the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org