findepi commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639609595
##########
baseline.gradle:
##########
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/java/**/*.java', 'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.17.0")
Review Comment:
Sooner or later we will add support for Java 21 and we will drop support for
Java 8. These two things do not have to depend on each other. Sadly, there is
no google java formatter version which can run under Java 21 and under Java 8,
so we need to make a choice which Java versions we can check source code
formatting with. We can either choose 8-17 or 11-21, but not the union. The
11-21 is an inevitable choice, unless we want to live in the past for ever.
Now, code formatting is very important for project day to day, but feels not
directly related to releases. The change here doesn't affect how we build
releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
