jbonofre commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661062567
##########
baseline.gradle:
##########
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.palantir.baseline-release-compatibility'
- apply plugin: 'com.diffplug.spotless'
+ // We need to update Google Java Format to 1.17.0+ to run spotless on JDK 8,
but that requires dropping support for JDK 8.
+ if (JavaVersion.current() != JavaVersion.VERSION_21) {
+ apply plugin: 'com.diffplug.spotless'
Review Comment:
That's my point: I would postpone the JDK21 update right now, and jump
directly to JDK21 without supporting JDK8 anymore.
I think it will be very difficult to support both JDK21 and JDK8 from
spotless/GJF standpoint. So, I would directly jump to new version when possible.
##########
baseline.gradle:
##########
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.palantir.baseline-release-compatibility'
- apply plugin: 'com.diffplug.spotless'
+ // We need to update Google Java Format to 1.17.0+ to run spotless on JDK 8,
but that requires dropping support for JDK 8.
+ if (JavaVersion.current() != JavaVersion.VERSION_21) {
+ apply plugin: 'com.diffplug.spotless'
Review Comment:
Yes exactly. It's what I proposed while ago in the Iceberg 2.0 discussion
thread. So, I propose:
- on 1.x (including 1.6.0 release currently in preparation), we keep JDK8
- for 2.x, we merge this PR and jump to JDK21
I can reply on the Iceberg 2.0 thread if you want or Piotr can start a new
thread about JDK21 on Iceberg 2.0.
I would love to have feedback on the Iceberg 2.0 thread 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
