nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1661056194
##########
baseline.gradle:
##########
@@ -45,7 +45,10 @@ subprojects {
apply plugin: 'com.palantir.baseline-reproducibility'
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.palantir.baseline-release-compatibility'
- apply plugin: 'com.diffplug.spotless'
+ // We need to update Google Java Format to 1.17.0+ to run spotless on JDK 8,
but that requires dropping support for JDK 8.
+ if (JavaVersion.current() != JavaVersion.VERSION_21) {
+ apply plugin: 'com.diffplug.spotless'
Review Comment:
@jbonofre we can't upgrade the GJF as long as we support JDK8 because
upgrading the GJF version will produce different results depending on the
underlying JDK it is executed with and so CI actions (and locally) will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
