nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1639894786
##########
baseline.gradle:
##########
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/java/**/*.java', 'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.17.0")
Review Comment:
Once Iceberg drops support for Java8 is when we will be able to update the
GJF version. As I mentioned earlier, we pinned the version so that
`spotlessApply` doesn't produce different formatting results depending on the
JDK version it is executed with. Since we release for JDK8, we need to use the
GJF version that works with JDK8.
The community is planning to drop JDK8 support (which only Hive depends on)
with Iceberg 2.0, which is also when we'll be upgrading most likely to 11-21.
That being said, we can only upgrade the GJF version once we also move to JDK
11-21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
