findepi commented on PR #10474: URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2166580206
> others here are more familiar with the build than I am, will let them comment. Is this removing some java version? no, i don't think so > Also, why all the code formatting, curious if we can remove those from the pr for ease of review? I had to update the spotless plugin and google format library to support Java 21. This resulted in dropped support for Java 8 and one-time code formatting changes -- clearly the new formatter is not backwards compatible. I can extract those changes to separate PR after we decide what to do with https://github.com/apache/iceberg/pull/10473. Without https://github.com/apache/iceberg/pull/10473, the formatting checks wouldn't run on CI at all, AFAIU. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
