nastra commented on code in PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#discussion_r1640996276
##########
baseline.gradle:
##########
@@ -60,8 +63,7 @@ subprojects {
spotless {
java {
target 'src/main/java/**/*.java', 'src/test/java/**/*.java',
'src/jmh/java/**/*.java', 'src/integration/java/**/*.java'
- // we use an older version of google-java-format that is compatible
with JDK 8
- googleJavaFormat("1.7")
+ googleJavaFormat("1.17.0")
Review Comment:
When I added spotless + configured GJF it would produce different results
depending on the JDK version that was used when executing `spotlessApply`. I
typically use `sdkman` to switch JDK version and from what I remember is that
when you run `spotlessApply` using JDK8 it would produce one formatting and a
different formatting when using JDK11+ (which you can also see in this PR,
where the formatting changed). Back then I looked into why it behaves the way
it does and it was due to different JDK versions might pick up a different GJF
version and so we had to pin the version to the latest one that was supported
by JDK8.
Typically whoever does a release is expected to run the release script using
JDK8 locally btw. I hope that helps in understanding the context as to why we
had to pin the GJF version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
