amogh-jahagirdar merged PR #11830:
URL: https://github.com/apache/iceberg/pull/11830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#issuecomment-2603021202
Thanks for the change @mrcnc , and thank you for reviewing @jbonofre!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jbonofre commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1922720993
##
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919521749
##
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateF
mrcnc commented on PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#issuecomment-2596937210
> Is there future intent to use the storageAccount/storageAccountName?
Otherwise, it's not being used currently but we're still parsing and storing it.
I don't have any future plans
mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919143306
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
ADLSLoca
mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919142646
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
ADLSLoca
mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919142646
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
ADLSLoca
mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1918901118
##
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915560522
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915391549
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915391549
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915391549
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915382736
##
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1893269744
##
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
bryanck commented on PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#issuecomment-2547272339
In retrospect this is probably a feature change we shouldn't have added in a
patch release. We should probably revert this and have another patch release.
--
This is an automated mess
ajreid21 commented on PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#issuecomment-2547163579
AzureProperties builds a map of account -> sasToken here when you create
ADLSFileIO using `adls.sas-token.` as the credential mechanism.
Prior to this change, the account passed
ajreid21 commented on PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#issuecomment-2547124997
This unfortunately is/was a breaking change 😞 - related to the concern
@jbonofre brought up.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
bryanck commented on PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#issuecomment-2476519972
Thanks for the PR @mrcnc ! And for the reviews @RussellSpitzer
@amogh-jahagirdar @jbonofre !
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
bryanck merged PR #11504:
URL: https://github.com/apache/iceberg/pull/11504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
bryanck commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1841274278
##
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemCli
bryanck commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1841269900
##
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSLocation.java:
##
@@ -30,14 +30,21 @@
*
* Locations follow a URI like structure to identify resources
bryanck commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1841268590
##
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemCli
RussellSpitzer commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1837256131
##
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSy
mrcnc commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1836917624
##
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemClien
jbonofre commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1836010627
##
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemCl
mrcnc opened a new pull request, #11504:
URL: https://github.com/apache/iceberg/pull/11504
This is a second attempt to resolve
https://github.com/apache/iceberg/issues/10127 but avoids using `java.net.URI`
for parsing, which was found to be problematic after the first attempt was
merged.
27 matches
Mail list logo
