ajreid21 commented on PR #11504: URL: https://github.com/apache/iceberg/pull/11504#issuecomment-2547163579
AzureProperties builds a map of account -> sasToken here when you create ADLSFileIO using `adls.sas-token.` as the credential mechanism. Prior to this change, the account passed in [here](https://github.com/apache/iceberg/blob/main/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L91) (which is used to lookup the sasToken from the map mentioned above) was parsed to include `.dfs.core.windows.net` so when generating the `adls.sas-token.` property to pass into ADLSFileIO, you needed to include `.dfs.core.windows.net` as part of the `adls.sas-token.` property name. After this change, we are parsing the ADLSLocation account to NOT include `adls.sas-token.`, so now the sasToken lookup from the map doesn't find the sasToken (unless the user updates their code to not include it in the property name anymore)... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
