amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915560522
##########
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##########
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
ADLSLocation location = new ADLSLocation(fullPath);
assertThat(location.path()).contains(path);
}
+
+ @ParameterizedTest
+ @CsvSource({
+ "abfs://contai...@account.dfs.core.windows.net/file.txt,
account.dfs.core.windows.net",
+ "abfs://contai...@account.dfs.core.usgovcloudapi.net/file.txt,
account.dfs.core.usgovcloudapi.net",
+ "wasb://contai...@account.blob.core.windows.net/file.txt,
account.blob.core.windows.net",
+ "abfs://account.dfs.core.windows.net/path, account.dfs.core.windows.net",
+ "wasb://account.blob.core.windows.net/path, account.blob.core.windows.net"
Review Comment:
Could we also add a case for wasbs?
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
"s3n", S3_FILE_IO_IMPL,
"gs", GCS_FILE_IO_IMPL,
"abfs", ADLS_FILE_IO_IMPL,
- "abfss", ADLS_FILE_IO_IMPL);
+ "abfss", ADLS_FILE_IO_IMPL,
+ "wasb", ADLS_FILE_IO_IMPL,
+ "wasbs", ADLS_FILE_IO_IMPL);
Review Comment:
Not completely sure I follow the concern, if a client is using WASB +
HadoopFileIO this means they explicitly configured it or are using a catalog
which defaults to using HadoopFileIO (e.g. the `HadoopCatalog`).
Adding this scheme mapping to `ResolvingFileIO` just makes it so that when
ResolvingFileIO is configured or defaulted to, if a path with "wasb/wasbs" is
encountered, we initialize the ADLS file IO. It shouldn't impact a user who has
already either explicitly configured HadoopFileIO or is defaulting to that.
Unless I'm missing something cc @danielcweeks @bryanck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
