amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1915391549
##########
azure/src/test/java/org/apache/iceberg/azure/adlsv2/ADLSLocationTest.java:
##########
@@ -89,4 +101,17 @@ public void testQuestionMarkInFileName(String path) {
ADLSLocation location = new ADLSLocation(fullPath);
assertThat(location.path()).contains(path);
}
+
+ @ParameterizedTest
+ @CsvSource({
+ "abfs://contai...@account.dfs.core.windows.net/file.txt,
account.dfs.core.windows.net",
+ "abfs://contai...@account.dfs.core.usgovcloudapi.net/file.txt,
account.dfs.core.usgovcloudapi.net",
+ "wasb://contai...@account.blob.core.windows.net/file.txt,
account.blob.core.windows.net",
+ "abfs://account.dfs.core.windows.net/path, account.dfs.core.windows.net",
+ "wasb://account.blob.core.windows.net/path, account.blob.core.windows.net"
+ })
+ void testHost(String path, String expectedHost) {
+ ADLSLocation location = new ADLSLocation(path);
+ assertThat(location.host()).contains(expectedHost);
Review Comment:
Yeah I checked this out locally to take a look, I think this assertion
should be a strict equals (just in case someone changes this behavior later on,
then the tests would catch this instead of masking another potential issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
