bryanck commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1841274278
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemClientBui
if (connectionString != null && !connectionString.isEmpty()) {
builder.endpoint(connectionString);
} else {
- builder.endpoint("https://"; + account);
+ builder.endpoint("https://"; + account + ".dfs.core.windows.net");
Review Comment:
I see, you are stripping off the domain below, so this isn't an issue. You
can ignore the above.
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSLocation.java:
##########
@@ -30,14 +30,21 @@
*
* <p>Locations follow a URI like structure to identify resources
*
- * <pre>{@code abfs[s]://[<container>@]<storage account host>/<file
path>}</pre>
+ * <pre>{@code
abfs[s]://[<container>@]<storageAccount>.dfs.core.windows.net/<path>}</pre>
Review Comment:
I feel we should stick to the URI format consistent w/ Hadoop's definition
(without assuming the domain)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
