mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1893269744
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
"s3n", S3_FILE_IO_IMPL,
"gs", GCS_FILE_IO_IMPL,
"abfs", ADLS_FILE_IO_IMPL,
- "abfss", ADLS_FILE_IO_IMPL);
+ "abfss", ADLS_FILE_IO_IMPL,
+ "wasb", ADLS_FILE_IO_IMPL,
+ "wasbs", ADLS_FILE_IO_IMPL);
Review Comment:
I would like to verify that updating this default behavior of
ResolvingFileIO is not considered a breaking change, since it could potentially
force clients using the WASB scheme with HadoopFileIO to update their
configuration. For example, if clients are currently using SAS tokens in an
[core-site.xml
file](https://hadoop.apache.org/docs/current/hadoop-azure/index.html#Configuring_Credentials),
then it seems they need to either configure these in the AzureProperties for
ADLSFileIO or explicitly configure HadoopFileIO as the implementation to get
the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
