mrcnc commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1836917624
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemClientBui
if (connectionString != null && !connectionString.isEmpty()) {
builder.endpoint(connectionString);
} else {
- builder.endpoint("https://"; + account);
+ builder.endpoint("https://"; + account + ".dfs.core.windows.net");
Review Comment:
I believe the `storageAccount` of `ADLSLocation` should be used for storing
the storage account name only. And since the ADLS APIs are accessed via
`dfs.core.windows.net` by default, I think it's appropriate to append it to the
storage account name here as the default. If users want to specify a different
hostname, they can use the `adls.connection-string` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
