bryanck commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1841268590
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemClientBui
if (connectionString != null && !connectionString.isEmpty()) {
builder.endpoint(connectionString);
} else {
- builder.endpoint("https://"; + account);
+ builder.endpoint("https://"; + account + ".dfs.core.windows.net");
Review Comment:
This deviates from the `abfs[s]` scheme defined by Hadoop, where the domain
is specified in the URI
([docs](https://hadoop.apache.org/docs/stable/hadoop-azure/abfs.html)). I feel
we should check if the account already ends with the domain and only append
then to support that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
