Re: [PR] Spark 3.4: Backport Spark actions changes in Spark rewrite_table_path procedure (#12006 #12172 #11929) [iceberg]

nastra commented on code in PR #12568: URL: https://github.com/apache/iceberg/pull/12568#discussion_r2002553616 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java: ## @@ -932,23 +1093,40 @@ protected void checkFileNum( int

Re: [PR] Spark 3.4: Backport Spark actions changes in Spark rewrite_table_path procedure (#12006 #12172 #11929) [iceberg]

nastra commented on code in PR #12568: URL: https://github.com/apache/iceberg/pull/12568#discussion_r2002553616 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java: ## @@ -932,23 +1093,40 @@ protected void checkFileNum( int

Re: [PR] Update documentation / add missing Iceberg table read properties [iceberg]

nastra commented on code in PR #12163: URL: https://github.com/apache/iceberg/pull/12163#discussion_r2002535122 ## docs/docs/configuration.md: ## @@ -32,10 +32,13 @@ Iceberg tables support table properties to configure table behavior, like the de | read.split.metadata-target-s

Re: [PR] Core: Make totalRecordCount optional in PartitionStats [iceberg]

nastra commented on code in PR #12226: URL: https://github.com/apache/iceberg/pull/12226#discussion_r2002513794 ## core/src/main/java/org/apache/iceberg/PartitionStats.java: ## @@ -78,7 +78,15 @@ public int equalityDeleteFileCount() { return equalityDeleteFileCount; }

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

nastra commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r2002508260 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) { throw new Unsuppor

Re: [PR] WIP: Interface based DataFile reader and writer API [iceberg]

pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2001465756 ## core/src/main/java/org/apache/iceberg/io/datafile/ReadBuilder.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Parquet, Core: Enable passing Variant tests [iceberg]

rdblue commented on PR #12559: URL: https://github.com/apache/iceberg/pull/12559#issuecomment-2734629109 Thanks for reviewing, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Iceberg Kafka Connect Sink cannot read table: java.lang.NumberFormatException: For input string: "60s" [iceberg]

lk-1984 commented on issue #12557: URL: https://github.com/apache/iceberg/issues/12557#issuecomment-2732011608 It is the `createFileSystem` method, and the configuration is the input so probably the configuration is incorrect. I have not specified such parameter that would have `60s` so it

Re: [I] Support commit retrie [iceberg-rust]

ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735359173 > > 1. We can introduce a new `ErrorKind::RetryableCommitError` to abstract kinds of catalog errors. > > Hi, I believe it should not be an extra kind. Instead, we can add a

Re: [PR] Core: Make totalRecordCount optional in PartitionStats [iceberg]

ajantha-bhat commented on code in PR #12226: URL: https://github.com/apache/iceberg/pull/12226#discussion_r2002428277 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -591,7 +591,7 @@ private static boolean isEqual( && stats1.positionD

Re: [I] Support commit retrie [iceberg-rust]

ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735358658 > [@ZENOTME](https://github.com/ZENOTME) Are you currently working on this? I'm looing to make some progress on this Hi @jonathanc-n, for the transaction part, we better wai

Re: [PR] Spark 3.4: Backport Spark actions changes in Spark rewrite_table_path procedure (#12006 #12172 #11929) [iceberg]

slfan1989 commented on PR #12568: URL: https://github.com/apache/iceberg/pull/12568#issuecomment-2735356388 @szehon-ho Could you please help review this PR? Thank you very much! We are currently dealing with a large-scale migration from Hive tables to Iceberg tables in our internal environm

Re: [PR] Core: Make totalRecordCount optional in PartitionStats [iceberg]

ajantha-bhat commented on code in PR #12226: URL: https://github.com/apache/iceberg/pull/12226#discussion_r2002425079 ## core/src/test/java/org/apache/iceberg/TestPartitionStats.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002241921 ## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [I] Rust doc is broken. [iceberg-rust]

liurenjie1024 commented on issue #1112: URL: https://github.com/apache/iceberg-rust/issues/1112#issuecomment-2735340888 > Is there a way to prevent the "ANCHOR" tag from being deleted again? For pyiceberg, we run a [docs build in CI](https://github.com/apache/iceberg-python/blob/a84689d3079

Re: [PR] Core: child HTTPClient should not close shared resources [iceberg]

nastra commented on code in PR #12566: URL: https://github.com/apache/iceberg/pull/12566#discussion_r2001478739 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java: ## @@ -323,6 +325,19 @@ public void testInvalidTimeout(String timeoutMsType) { .hasMessage(

[I] Rust doc is broken. [iceberg-rust]

liurenjie1024 opened a new issue, #1112: URL: https://github.com/apache/iceberg-rust/issues/1112 ### Apache Iceberg Rust version None ### Describe the bug The generated rust doc book is broken: https://rust.iceberg.apache.org/api.html This is introduced by https:

Re: [PR] Flink: Add support for Flink 2.0 [iceberg]

stevenzwu commented on code in PR #12527: URL: https://github.com/apache/iceberg/pull/12527#discussion_r2002394034 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -138,6 +141,12 @@ class IcebergFilesCommitter extends AbstractStr

Re: [I] Support commit retrie [iceberg-rust]

Xuanwo commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735265884 > 1. We can introduce a new `ErrorKind::RetryableCommitError` to abstract kinds of catalog errors. Hi, I believe it should not be an extra kind. Instead, we can add a `retry

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2735255829 @nastra recreated the IDEA project files using the following ``` gradle cleanIdea gradle idea ``` The imports are good now Thanks -- This is an auto

Re: [PR] Core, Spark 3.5: Apply Ignore Residuals to Delete Filtering [iceberg]

RussellSpitzer commented on PR #12479: URL: https://github.com/apache/iceberg/pull/12479#issuecomment-2735243973 Thanks @aokolnychyi , @rdblue , @pvary , @wypoon for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Core, Spark 3.5: Apply Ignore Residuals to Delete Filtering [iceberg]

RussellSpitzer merged PR #12479: URL: https://github.com/apache/iceberg/pull/12479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Make totalRecordCount optional in PartitionStats [iceberg]

nastra commented on code in PR #12226: URL: https://github.com/apache/iceberg/pull/12226#discussion_r2000690777 ## core/src/main/java/org/apache/iceberg/PartitionStats.java: ## @@ -78,7 +78,16 @@ public int equalityDeleteFileCount() { return equalityDeleteFileCount; }

Re: [PR] REST: HTTPRequest.baseUri() should be nullable [iceberg]

nastra commented on code in PR #12556: URL: https://github.com/apache/iceberg/pull/12556#discussion_r2000458253 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPRequest.java: ## @@ -107,6 +105,18 @@ public void malformedPath() { "Received a malformed path for a

[PR] Enable discussion. [iceberg-rust]

liurenjie1024 opened a new pull request, #1103: URL: https://github.com/apache/iceberg-rust/pull/1103 ## What changes are included in this PR? Apache infra team has enabled github discussion managed by .asf.yml. Update .asf.yml to enable discussion. -- This is an automated

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

amogh-jahagirdar commented on code in PR #12511: URL: https://github.com/apache/iceberg/pull/12511#discussion_r2002321359 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -612,6 +613,14 @@ public boolean dropView(TableIdentifier identifier) { throw ne

Re: [PR] Build: Bump mkdocstrings-python from 1.16.5 to 1.16.6 [iceberg-python]

sungwy merged PR #1811: URL: https://github.com/apache/iceberg-python/pull/1811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002331662 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicKeySelector.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] fix: fix http custom headers for rest catalog [iceberg-rust]

Xuanwo merged PR #1010: URL: https://github.com/apache/iceberg-rust/pull/1010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

kevinjqliu commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002336680 ## pyiceberg/types.py: ## Review Comment: sure that sounds great! i just want to make sure we are tracking the type promotion feature for pyiceberg -

Re: [I] Rust doc is broken. [iceberg-rust]

kevinjqliu commented on issue #1112: URL: https://github.com/apache/iceberg-rust/issues/1112#issuecomment-2735217982 Is there a way to prevent the "ANCHOR" tag from being deleted again? For pyiceberg, we run a [docs build in CI](https://github.com/apache/iceberg-python/blob/a84689d307949a8e

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002331662 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicKeySelector.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Found

[PR] feat: check whether table ops conflict when committing [iceberg-python]

YinZheng-Sun opened a new pull request, #1816: URL: https://github.com/apache/iceberg-python/pull/1816 check whether table ops conflict when committing related to #1678 # Rationale for this change # Are these changes tested? # Are there any user-facing cha

Re: [PR] Spark: Add some tests for variant fixup [iceberg]

XBaith commented on code in PR #12497: URL: https://github.com/apache/iceberg/pull/12497#discussion_r2002321202 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/RandomData.java: ## @@ -217,6 +218,11 @@ public Object map(Types.MapType map, Supplier keyResult, Supp

Re: [PR] Build: Bump griffe from 1.6.0 to 1.6.1 [iceberg-python]

sungwy merged PR #1814: URL: https://github.com/apache/iceberg-python/pull/1814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

[I] "manylinux_2_34_aarch64" wheel request [iceberg-python]

gabor-one opened a new issue, #1807: URL: https://github.com/apache/iceberg-python/issues/1807 ### Feature Request / Improvement Hi Everyone! Is there any reason why manylinux_2_34_aarch64 wheel has not been built? Can we add it? Reason: pyiceberg/avro/decoder_fast.pyi i

Re: [PR] Upsert: Don't produce empty snapshots [iceberg-python]

kevinjqliu commented on code in PR #1810: URL: https://github.com/apache/iceberg-python/pull/1810#discussion_r2002333427 ## pyiceberg/table/__init__.py: ## @@ -1198,10 +1198,11 @@ def upsert( update_row_cnt = len(rows_to_update) -# build the

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002254795 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -70,6 +76,20 @@ public static Type fromTypeName(String typeString) { return TYPES.get(lowe

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

amogh-jahagirdar commented on PR #12511: URL: https://github.com/apache/iceberg/pull/12511#issuecomment-2735196052 Thank you @hsiang-c for this, and thanks @ebyhr @nastra for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Core: JDBCCatalog's dropView() should purge metadata files if GC is enabled [iceberg]

amogh-jahagirdar merged PR #12511: URL: https://github.com/apache/iceberg/pull/12511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002311502 ## pyiceberg/types.py: ## Review Comment: I just read it again, it the spec seems to suggest the following: - date to timestamp and timestamp_ns is su

Re: [I] Rust doc is broken. [iceberg-rust]

Xuanwo closed issue #1112: Rust doc is broken. URL: https://github.com/apache/iceberg-rust/issues/1112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [PR] feat: Add byte hint for fetching parquet metadata [iceberg-rust]

liurenjie1024 merged PR #1108: URL: https://github.com/apache/iceberg-rust/pull/1108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] fix: fix http custom headers for rest catalog [iceberg-rust]

liurenjie1024 commented on PR #1010: URL: https://github.com/apache/iceberg-rust/pull/1010#issuecomment-2735180655 cc @Xuanwo to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002306704 ## pyiceberg/types.py: ## Review Comment: Thanks for chiming in @smaheshwar-pltr . Appreciate the review. I read the last column that mentioned that p

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002311502 ## pyiceberg/types.py: ## Review Comment: Thanks for chiming in @smaheshwar-pltr . Appreciate the review. I just read the spec again, and it the spec seems

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002306704 ## pyiceberg/types.py: ## Review Comment: Thanks for chiming in @smaheshwar-pltr . Appreciate the review. I read the last column that mentioned that p

Re: [PR] Partition Writer Support Part 1: add partition splitter [iceberg-rust]

jonathanc-n commented on code in PR #1040: URL: https://github.com/apache/iceberg-rust/pull/1040#discussion_r2002302621 ## crates/iceberg/src/arrow/record_batch_partition_splitter.rs: ## @@ -0,0 +1,422 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [I] Rust doc is broken. [iceberg-rust]

Xuanwo closed issue #1112: Rust doc is broken. URL: https://github.com/apache/iceberg-rust/issues/1112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [PR] fix: Rust doc fix [iceberg-rust]

Xuanwo merged PR #1113: URL: https://github.com/apache/iceberg-rust/pull/1113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] refactor: Split manifest crate [iceberg-rust]

liurenjie1024 commented on PR #1109: URL: https://github.com/apache/iceberg-rust/pull/1109#issuecomment-2735154651 > @liurenjie1024 I accidnetally discarded the changes so i made new pull request. I should have made the correct changes. The conflict with #1098 is causing a lot of unresolvab

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002243804 ## api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java: ## @@ -327,12 +329,34 @@ public void testVariantUnsupported() { .hasMessage("C

Re: [PR] refactor: Split manifest crate [iceberg-rust]

liurenjie1024 commented on code in PR #1109: URL: https://github.com/apache/iceberg-rust/pull/1109#discussion_r2002293527 ## crates/iceberg/src/spec/manifest/mod.rs: ## @@ -0,0 +1,805 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] Core, Spark 3.5: Apply Equality Deletes when Doing Copy on Write [iceberg]

aokolnychyi commented on code in PR #12479: URL: https://github.com/apache/iceberg/pull/12479#discussion_r2002162728 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -575,8 +591,13 @@ private Iterable>> deleteManifestRea matchingManifests,

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002256813 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -58,9 +58,15 @@ private Types() {} .put(BinaryType.get().toString(), BinaryType.get())

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on PR #12346: URL: https://github.com/apache/iceberg/pull/12346#issuecomment-2735135694 > Also, (as can't comment on files that are not in the change) > > Do we need to add Geo types to following places? > > 1. Types.java TYPES constant? > 2. TestSchema

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002274978 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [I] RestCatalog append table is slow (2+s) [iceberg-python]

sungwy commented on issue #1806: URL: https://github.com/apache/iceberg-python/issues/1806#issuecomment-2735096521 Hi @HungYangChang - thanks for posting the logs! A couple of things to unpack here: `_dataframe_to_data_files` produces an `Iterator`, which means that the task of a

[PR] fix: Rust doc fix [iceberg-rust]

jonathanc-n opened a new pull request, #1113: URL: https://github.com/apache/iceberg-rust/pull/1113 ## Which issue does this PR close? - Closes #1112 . ## What changes are included in this PR? Added back original Anchor tags -- This is an automated message from the

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002238713 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +568,124 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002287031 ## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002286357 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +561,120 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002286654 ## core/src/main/java/org/apache/iceberg/SchemaParser.java: ## @@ -277,6 +313,17 @@ private static Types.MapType mapFromJson(JsonNode json) { } } + pr

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002285965 ## api/src/test/java/org/apache/iceberg/types/TestTypes.java: ## @@ -90,5 +90,42 @@ public void testNestedFieldBuilderIdCheck() { assertThatExceptionOfType(

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002279100 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +561,120 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002277670 ## api/src/main/java/org/apache/iceberg/types/EdgeInterpolationAlgorithm.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002277131 ## api/src/main/java/org/apache/iceberg/types/EdgeInterpolationAlgorithm.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002260593 ## core/src/main/java/org/apache/iceberg/util/GeometryUtil.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[PR] feat: Support `PartitionStats` [iceberg-rust]

jonathanc-n opened a new pull request, #: URL: https://github.com/apache/iceberg-rust/pull/ ## Which issue does this PR close? Part of #1102 ## What changes are included in this PR? Added partition stats outline ## Are these changes tested?

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002260045 ## build.gradle: ## @@ -348,6 +348,7 @@ project(':iceberg-core') { implementation libs.jackson.databind implementation libs.caffeine implementatio

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002250909 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002255215 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -70,6 +75,20 @@ public static Type fromTypeName(String typeString) { return TYPES.get(lowe

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002253930 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002251470 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] Build: Bump mkdocs-literate-nav from 0.6.1 to 0.6.2 [iceberg-python]

sungwy merged PR #1812: URL: https://github.com/apache/iceberg-python/pull/1812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002249208 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002239402 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +568,124 @@ public int hashCode() { } } + public static class GeometryType exte

[I] Introduce TimestampNs, TimestampTzNs support for Bucket transforms [iceberg-rust]

sungwy opened a new issue, #1110: URL: https://github.com/apache/iceberg-rust/issues/1110 ### Is your feature request related to a problem or challenge? While working on introducing `timestamp_ns` and `timestamptz_ns` support in PyIceberg, I noticed that Bucket transform in iceberg-ru

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002243093 ## core/src/main/java/org/apache/iceberg/SchemaParser.java: ## @@ -141,11 +145,39 @@ static void toJson(Types.MapType map, JsonGenerator generator) throws IOExc

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002241118 ## core/src/test/java/org/apache/iceberg/TestSchemaParser.java: ## @@ -142,4 +143,31 @@ public void testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Lite

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002238179 ## core/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -129,28 +135,37 @@ protected boolean supportsVariant() { return false; } + protecte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002238483 ## api/src/test/java/org/apache/iceberg/types/TestTypes.java: ## @@ -81,6 +81,56 @@ public void fromPrimitiveString() { .withMessage("Cannot parse type

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002237306 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002237306 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002237048 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +563,122 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] API, Core: Add geometry and geography types support [iceberg]

Kontinuation commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r2002236482 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -543,6 +561,120 @@ public int hashCode() { } } + public static class GeometryType exte

Re: [PR] Build: Bump pre-commit from 4.1.0 to 4.2.0 [iceberg-python]

sungwy merged PR #1813: URL: https://github.com/apache/iceberg-python/pull/1813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Core, Spark 3.5: Apply Equality Deletes when Doing Copy on Write [iceberg]

RussellSpitzer commented on code in PR #12479: URL: https://github.com/apache/iceberg/pull/12479#discussion_r2002211363 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -575,8 +591,13 @@ private Iterable>> deleteManifestRea matchingManifests,

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002211292 ## pyiceberg/transforms.py: ## Review Comment: Yes we should! Currently I'm getting the following exception from pyiceberg_core, and it looks like iceberg-r

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

smaheshwar-pltr commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002210663 ## pyiceberg/types.py: ## Review Comment: Probably missing something but I read [here](https://iceberg.apache.org/spec/#schema-evolution) that `dat

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002210588 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicKeySelector.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002191598 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java: ## @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002196096 ## pyiceberg/types.py: ## @@ -703,6 +718,44 @@ class TimestamptzType(PrimitiveType): root: Literal["timestamptz"] = Field(default="timestamptz") +class T

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2002195447 ## pyiceberg/types.py: ## Review Comment: I don't see any type promotions supported to and from `timestamp_ns` and `timestamptz_ns` types in the Spec: h

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002191598 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java: ## @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Flink: Dynamic Iceberg Sink Contribution [iceberg]

stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r2002191598 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java: ## @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark 3.5, Core: Supplement test case for metadata_log_entries after expire snapshot [iceberg]

github-actions[bot] closed pull request #11901: Spark 3.5, Core: Supplement test case for metadata_log_entries after expire snapshot URL: https://github.com/apache/iceberg/pull/11901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Spark 3.5, Core: Supplement test case for metadata_log_entries after expire snapshot [iceberg]

github-actions[bot] commented on PR #11901: URL: https://github.com/apache/iceberg/pull/11901#issuecomment-2734998760 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] Deleting metadata(expire_snapshots doesn't help...) [iceberg]

github-actions[bot] commented on issue #11169: URL: https://github.com/apache/iceberg/issues/11169#issuecomment-2734998718 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Incorrect schema used when using time-travel [iceberg]

github-actions[bot] commented on issue #11162: URL: https://github.com/apache/iceberg/issues/11162#issuecomment-2734998684 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

  1   2   3   >