RussellSpitzer commented on code in PR #12479:
URL: https://github.com/apache/iceberg/pull/12479#discussion_r2002211363
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -575,8 +591,13 @@ private
Iterable<CloseableIterable<ManifestEntry<DeleteFile>>> deleteManifestRea
matchingManifests,
manifest ->
ManifestFiles.readDeleteManifest(manifest, io, specsById)
- .filterRows(dataFilter)
- .filterPartitions(partitionFilter)
+ .filterRows(entryFilter)
+ .filterPartitions(
+ Expressions.and(
+ partitionFilter,
+ Projections.inclusive(
+ specsById.get(manifest.partitionSpecId()),
caseSensitive)
Review Comment:
Just forgot! I was testing here first and forgot to use the cache after I
implemented it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
